-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Sponsor Blocking #2554
Comments
I just take a look at the API and it should be simple to get timecodes I will look on making a script for mpv if everything work as expected I will try to do the same here |
+1 for this, love this on my computer |
@polymorphicshade nice, I think there should be a feature to hide button for those who want |
@Z3ROGRAV1TYx yeah currently if that setting is disabled, the icon will be hidden from the video player |
LGTM. Does it highlight the labeled seekbar segments? Is there an undo? |
@illeatmyhat basically I plan to mimic the browser plugin as much as I can, the screenshots above are just something I threw together in a day or so. |
Personally, I don't think this is something that NewPipe should do considering we already can't support creators through Youtube's ads and most people probably won't just give money directly to all the creators they like since that's not really economically viable. But, this also gives a precedent to altering the video the creators make intentionally and creating blacklists of segments of videos. I think modifying or blacklisting content (or parts of content) is not a rabbit-hole that NewPipe should participate in. |
@lionirdeadman I disagree. I believe more in giving viewers control on whether or not they view ads/sponsors than succumbing to intrusive ads. If the viewer wants to support the creator, they can simply not use this feature. |
@lionirdeadman I want to see the fall of Youtube. I hope to see creators moving to a more decentralize platform. Peertube+Liberapay perhaps? Right now one of the main attractive point of NewPipe is to skip ads. See this feature as an extension of this main point. |
@aloisdg Well, that's what you think is one of the main attractive point. Currently, Newpipe doesn't show ads because it's impossible, not out of choice. For me, Newpipe is simply what I can use to watch videos without the proprietary Youtube application. And sure, it would be great if Peertube + a payment service were to succeed Youtube but it's not by removing bread from people's mouth that it should be done, that's just unethical at best. |
The idea of blocking ads at video segment level sounds all right to me. But the proposed approach (using SponsorBlock API) is bad for user privacy, because it allows SponsorBlock owners to learn exactly which video you watch and when. I'd prefer if NewPipe downloaded entire database with timestamps (it is not big, — AFAIK, just few megabytes right now) and used it to block ads without consulting SponsorBlock servers. |
@lionirdeadman when I talk to non tech-savvy people about NewPipe, the native adblocking is a better selling point that the freedom of the software. @Alexander-- Downloading the db to access it offline could be optional. |
As an optional feature implemented though, it would be great. And is what I'm hoping for. |
Well that's sad and well, somewhat untrue, we don't do any adblocking to my knowledge, we just get the video file and that doesn't have any ads to begin with. |
I personally don't want to waste any time on advertisements, whether native or sponsored, and given the complete lack of regulations in this regard we will absolutely get yet another NordVPN fiasco that will damage many more people bc they were featured in videos of someone they watch. It already got worse in Russia where many youtubers started advertising stuff like gambling, real or CS GO skin one, shady G2A-esque game stores, and so on. By skipping ads I am protecting myself from the wild west that is the internet. It ain't like creators won't get paid from me not watching the ads they were asked to put in the video themselves in the first place. edit: Corrected what i wanted to say, but two thoughts to add to this:
|
@lionirdeadman Alright my term is quite misleading. NewPipe doesnt use an adblocking system but is ad-free. |
Personally, I found your statement very clear. NewPipe isn't using an adblocking system, it just ONLY retrieves the videos, and the ads do not come alongside it. I don't think this needs to be argued for anymore. Ads in general only support channels very little anyways. Waste your time, etc. 99% of people use an adblocker now adays anyways. Personally I will go out of my way to block every single ad on a page if I can. They take of space, bloat the page, can introduce scummy tracking techniques, etc. They ruin the internet. This is not the point of this issue here. I think Sponsorblock implementation would be great though, it would be optional so if people had an issue with disabling sponsors then they'd keep it disabled. If they want sponsor messages, they enable it. Sponsor messages imo are the biggest waste of my time, and I skip over them anyways. On the browser I use sponsorblock anyways. I would never buy something personally simply because of someone promoting something, if anything makes me buy it less. I do my own research. So they are useless to me. I hate them wasting my time, Sponsorblock just makes the process of skipping them 100x easier and providing a more seamless watching experience. So I'm hoping it gets implemented in the near future and I'm sure many other people do as well. |
@polymorphicshade any update on when you’ll be ready to do a PR? Or do you want any help? |
I have most of want I want done; I'm just looking into something else for a bit until I create a PR. Probably will make one some time this weekend. |
Are we supposed to break out the folding chairs and fight now? |
Skimmed the PR, so it seems like we are close to having this merged and officially supported soon? Or are we quite a ways away? |
I wouldn't say it's close to being merged, I'm waiting on a much bigger PR to be merged before I continue working on fixing the progress bar overlay. However aside from simply skipping ads automatically, I'm not sure what other SponsorBlock-specific features would be worth putting time in to, considering NewPipe's intent on being a light front-end for YouTube. |
SponsorBlock does have a few more things it skips now that may be worth considering, not sure how much more weight it'd put on Newpipe. |
Since NewPipe reads the page html, would it be possibile to load the ads but not showing them, somehow fooling YT ads system? |
That's an entirely different different topic, please create a new issue. |
So is this issue's idea would be better then #4437 ? I can't see how, blocking ads is already depriving creators of earnings, but you guys seem to have no problem with this. |
@Piruzzolo think of it this way: if you watch TV and the channel doesn't show ads to you, but tricks the ad companies into thinking you actually did see the ads, then this is essentially theft. Instead, if the channel lets you decide to watch or skip an ad, and the ad company knows about this, then it's ok. |
@Piruzzolo That also could get the creator of the videos you are watching banned from adsense. |
Team NewPipe decided not to support SponsorBlock in NewPipe. Team NewPipe doesn't want to be a gatekeeper, deciding which forms of advertising we want to allow in the app, and which we don't want to allow. We've taken the time to write down our reasoning in detail. Please see our position paper for more information. |
That's very sad to hear, especially seeing Vanced has introduced this feature. I fail to see the issue seeing it would be toggleable so users who wish to see sponsors can. They could also choose to use their own lists. Sponsorblock already offers multiple toggles for different forms of advertising so if users want some but not others they can, or just choose to have all. I think this will hold us back, and just continue to be a pain to the users who already manually skip the sponsors anyways, so this makes literally no difference to them besides requiring to manually skip it. Sponsorblock could simply be off by default. I completely understand the concerns, and there is a big difference between sponsors and ads, however again people who don't care will be manually skipping them anyways. Sponsorblock would have just made it more seamless. |
Thank you for the position paper. I agree with the general sentiment that newpipe should not block ethical options for advertising by default. However I don't quite see the "gatekeeper" function you described. Current versions of SponsorBlock allow users to tag sections of the video for many things users might want to skip, including intro sequences. It also lets users choose between a number of options such as showing a skip button or just highlighting it in the seek bar. Since this is provided by other applications, I feel that the net effect is more to reduce the viability of using free software options over proprietary solutions than to encourage more ethical forms of advertisement. |
While I agree with the paper, SponsorBlock does not in any way affect the creators who get sponsorships. As far as I can tell, creators get paid a fixed sum as soon as the video with the sponsorship is published, and whether users skip the sponsor segments do not in any way affect the creator. As @NotAFile stated, SponsorBlock also allows users to selectively skip (or skip by clicking a button) so the gatekeeper argument doesn't seem to be valid. |
I think SponsorBlock is an excellent idea and enjoy polymorphicsshade fork! Please keep it up. |
SponsorBlock not just skip ads only, but also intro, outro and subscription reminder etc. There are some authorized anime distributors (Ani-One Asia, Muse Asia) that release full-length anime episodes to YouTube. Other viewers and I submitted the intro and outro of those animes the distributors released so others could skip those not-so-important parts. |
There's a project using a crowd-sourced tagging database to skip over parts of the video dedicated to sponsorship and advertisements.
https://github.com/ajayyy/SponsorBlock
I think that it could be an interesting idea to integrate.
The text was updated successfully, but these errors were encountered: