Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Play videos in NewPipe that youtube-dl can fetch #2568

Closed
fnadde42 opened this issue Aug 27, 2019 · 6 comments
Closed

[Feature Request] Play videos in NewPipe that youtube-dl can fetch #2568

fnadde42 opened this issue Aug 27, 2019 · 6 comments
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor

Comments

@fnadde42
Copy link

fnadde42 commented Aug 27, 2019

NewPipe is really an awesome app and I could go on and on how much I love it. However, there are a lot more video services than YouTube that I would like to use through NewPipe. Developing ways to fetch the video from these services would be a pain but luckily there already is a way to do that called youtube-dl (which I'm sure many have heard of).

What I envision is that a "service" is added in the list where "YouTube, SoundCloud..." is called either "youtube-dl" or "Generic". A popup informs user that using the generic video fetcher will only give the user the video and features related to video (like play, pause, forward, backwards, subtitles and downloading audio or video) and that the "service" is based on external software with no guarantees that it will work (and the usual disclaimers about who to turn to when things go south).

Instead of having a search bar there is a place to paste a URL. If a user copies text that is a URL, the context menu could maybe show a "view in newpipe". Or if a user is on a web page with a video, the user could share the URL to NewPipe.

Youtube-dl is GNU GPL compatible and supported by a solid community that is hell bent on being able to play and download any video on the web and combined with the smooth interface of NewPipe... nothing would be able to stop such a force.

@Stypox
Copy link
Member

Stypox commented Aug 27, 2019

The problem with youtube-dl is that it is made in Python, and is thus not embeddable in an android app. Even though Python interpreters for Android exist, they are not lightweight and would make the app heavier and slower.

@fnadde42
Copy link
Author

I figured you had already discussed this but was curious as to why it hadn't happened. Thanks for the explanation!

@mihawk90
Copy link

I've also always been wondering why you did your own downloader, kinda makes sense now...

Anyway, the Python Wiki states that it would be possible to trans-compile Python into java using VOC. I'm not into Android development, so probably a long shot, but might this be an option?

@Stypox Stypox added discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor labels Oct 2, 2019
@nyanpasu64
Copy link
Contributor

You can use Nuitka to compile youtube-dl into a binary or shared object (35MB on win64) that depends on the Python shared object (3.6MB on win64) but not a filesystem package tree. It reduces load time slightly, but launching the .exe from a clean cache (no previous runs) takes 3 seconds on a SSD. But it's still quite bloated, and I don't know if Nuitka supports targeting ARM/Android shared libraries. I think this is a very unusual architecture and may not necessarily work (or well).

@Stypox
Copy link
Member

Stypox commented Aug 13, 2020

Closing this since this is not going to be done, the way forward is with NewPipeExtractor and probably extensions

@opusforlife2
Copy link
Collaborator

#2415 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app requires extractor change This issue requires a change to the extractor
Projects
None yet
Development

No branches or pull requests

5 participants