Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search suggestions #3419

Closed
wb9688 opened this issue Apr 11, 2020 · 3 comments · Fixed by #3471
Closed

Search suggestions #3419

wb9688 opened this issue Apr 11, 2020 · 3 comments · Fixed by #3471
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project

Comments

@wb9688
Copy link
Contributor

wb9688 commented Apr 11, 2020

Describe the feature you want

Show search suggestions, i.e. "Did you mean: …".

Additional context

NewPipeExtractor already has the relevant code to extract it, but apparently that's never called in the app.

@wb9688 wb9688 added feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Apr 11, 2020
@B0pol
Copy link
Member

B0pol commented Apr 11, 2020

It requires extractor changes. Currently, the provided method doesn't work for youtube or youtube music (and for other services it returns null)

@B0pol
Copy link
Member

B0pol commented Apr 11, 2020

I found there are in fact two way to have suggestion, and they aren't the same:

  • showingResultFor: it means you have searched [something] but youtube think it is a typo, so we gave you results for [corrected something].
  • didYouMean: it means you have searched [something] but youtube think it is a typo. Youtube still gave you results for [something], but shows you that you should try [corrected something].

I'll open a PR soon to fix youtube normal, giving showResultsFor instead of didYouMean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants