Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video start in portrait mode even though the video is in landscape #3485

Closed
ThomasLeigh opened this issue Apr 25, 2020 · 9 comments · Fixed by #2907
Closed

Video start in portrait mode even though the video is in landscape #3485

ThomasLeigh opened this issue Apr 25, 2020 · 9 comments · Fixed by #2907
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@ThomasLeigh
Copy link

ThomasLeigh commented Apr 25, 2020

Hello,

I’ve just installed NewPipe v0.19.2 on SAVIO Smart TV Box TB-P01 (Android 7.1 Nougat), running on Samsung TV UE46ES5500WXXH. The thing is that I cannot force videos to be displayed on full screen - they are displayed in a very small size (I don’t mean a popup window - which also is small and I can’t enlarge it), even if permissions to display over the apps are granted.

@ThomasLeigh ThomasLeigh added the bug Issue is related to a bug label Apr 25, 2020
@wb9688
Copy link
Contributor

wb9688 commented Apr 26, 2020

Could you test the RC of v0.19.3? It should have fixed a lot of Android TV related stuff

@ThomasLeigh
Copy link
Author

Yeah, it could be fantastic! Where can I find it? Cannot see this ver. on GitHub release page.

@ThomasLeigh
Copy link
Author

Oh, I see: #3479 Haven’t known that such a ver. exists.

@ThomasLeigh
Copy link
Author

@wb9688 Unfortunately it didn’t help. :( The issue persists in my case. I’ve tried all the available picture adjustments while viewing a video (upper right icons), to no avail.

@wb9688
Copy link
Contributor

wb9688 commented Apr 26, 2020

Hmm… is "very small" about 32% of the screen (assuming your screen is 16:9 and your video is 16:9 as well)? If so, you probably have it in portrait mode instead of landscape mode. Could you try pressing the button to switch?

@ThomasLeigh
Copy link
Author

Could you try pressing the button to switch?

Thank You very much, it works!

I’m not sure should I create a separate thread for this, but there is one more thing: whenever I add a NewPipe icon to desktop icons (this particular smart tv has its own method for adding app icons to desktop), another icons shows up alongside the NewPipe’s: a yellow shield. Once I choose it it displays “Leaks in org.schabi.newpipe.debug”.

@Stypox
Copy link
Member

Stypox commented Apr 30, 2020

@ThomasLeigh that's normal, as what you downloaded is a debug apk. When the new version will be released it won't exist ;-)

@TobiGr
Copy link
Contributor

TobiGr commented Apr 30, 2020

We should enforce landscape on TVs if the video is a landscape video otherwise use portrait.
That should be quite easy to do.

@TobiGr TobiGr reopened this Apr 30, 2020
@TobiGr TobiGr added the Android TV Issue is related to Android TV label Apr 30, 2020
@B0pol
Copy link
Member

B0pol commented May 1, 2020

Why only or TVs? I've never understood why videos are in portrait on fresh NewPipe installs, when most of the videos actually are in landscape.

Btw #2907 exactly does that on all devices.

@Stypox Stypox added the player Issues related to any player (main, popup and background) label May 2, 2020
@Stypox Stypox linked a pull request May 6, 2020 that will close this issue
@B0pol B0pol changed the title No full screen videos on a smart tv box (Android 7). Video start in portrait mode even though the video is in landscape May 10, 2020
@B0pol B0pol removed the Android TV Issue is related to Android TV label May 10, 2020
@B0pol B0pol closed this as completed May 10, 2020
@B0pol B0pol reopened this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants