Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background player selection to main (video player) #3733

Closed
cain-dev opened this issue Jun 3, 2020 · 2 comments · Fixed by #2907
Closed

Background player selection to main (video player) #3733

cain-dev opened this issue Jun 3, 2020 · 2 comments · Fixed by #2907
Labels
feature request Issue is related to a feature in the app

Comments

@cain-dev
Copy link

cain-dev commented Jun 3, 2020

This video is playing on the background If i select the thumbnail here Just reset the video
i think if im selecting the thumbnail of the video on a background list should just put the video on the foreground, resetting makes no sense
@cain-dev cain-dev added the feature request Issue is related to a feature in the app label Jun 3, 2020
@Stypox
Copy link
Member

Stypox commented Jun 3, 2020

There is already a way to switch players (see the three-dot menu). The thumbnail is already used as a drag point for reordering the queue, so I don't think it would be a good idea to assign it another purpose. Also, the "Switch to main player" is not an obvious choice when applied to an item, since it is more of a queue-related action. Eventually I would prefer to have "Show info" as the action of pressing on item thumbnails, though I don't think that's needed either since it can be accessed via the long press menu.

@cain-dev
Copy link
Author

cain-dev commented Jun 3, 2020

"There is already a way to switch players (see the three-dot menu)."
Yeah, i saw it

"The thumbnail is already used as a drag point for reordering the queue, so I don't think it would be a good idea to assign it another purpose."

no, this is correct, this is not the part that i think should be changed, this is very intuitive and natural

"Also, the "Switch to main player" is not an obvious choice when applied to an item, since it is more of a queue-related action"

the thing is that i have no "direct access" to go to the main player, and anything goes, something like this will be good enough:
go to

every queue list i saw is something like this:

Select something here
unnamed

Goes here
download

@Stypox Stypox linked a pull request Jun 4, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants