Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background/pop-up/full-screen players open at the same time #3737

Closed
theFireProject opened this issue Jun 4, 2020 · 6 comments · Fixed by #2907
Closed

Background/pop-up/full-screen players open at the same time #3737

theFireProject opened this issue Jun 4, 2020 · 6 comments · Fixed by #2907
Labels
bug Issue is related to a bug

Comments

@theFireProject
Copy link

theFireProject commented Jun 4, 2020

Version

0.19.5

Steps to reproduce the bug

  1. Go to a video
  2. Start background playback
    tap 'Background'
  3. Start popup player
    tap 'Popup'
  4. Start in-app full screen player
    tap play button on the video thumbnail

Expected behavior

If a video is started in a different playback mode (background/popup/full-screen) while NewPipe is already playing a video, the first playback mode should be fully stopped, not only paused.
There should only be one player or playback mode open at a time.

Examples

  • There shouldn't be a paused pop-up player over the full-screen player playing a video.
  • There shouldn't be a paused background player (in the form of a second NewPipe notification) while a video is playing in pop-up mode.
  • When the playback method is changed, the notification of the first playback mode (background/popup) should be removed.

Actual behaviour

If done in the right order, it's possible to have two NewPipe playback notifications active, a pop-up player and the full-screen player at the same time.

Explanation
This behaviour doesn't make any sense because it's only possible to play one mode at a time. I don't need a paused pop-up player in front of my full- screen player if I'm trying to watch in full-screen mode. Also it is disturbing to have two playback notifications at the same time: A paused background player and a playing pop-up player. It only leads to mistakes because of tapping the wrong notification.

Screenshots

Video player

Screenshot_20200604-055625_NewPipe
   pop-up player and full-screen player
   two NewPipe notifications on the notification bar

Notification center

20200604_062132
   duplicate NewPipe playback notification

@theFireProject theFireProject added the bug Issue is related to a bug label Jun 4, 2020
@theFireProject theFireProject changed the title Duplicate playback in audio, pop-up, player mode at the same time Background/pop-up/full-screen players open at the same time Jun 4, 2020
@androidSwDev099
Copy link

androidSwDev099 commented Jun 4, 2020

I would prefer to be able to have multiple players at the same time. I may be listening to a playlist in background mode with the background player. Now I decide to take a break and watch a video outside of the background player - either in a popup player or full screen player while the background player is paused. When I finish watching this break video, I currently have the option to resume the background player and continue listening to the playback list where I left of without having to reload that list. Please don't disable the flexibility to use multiple players in NewPipe.

@wb9688
Copy link
Contributor

wb9688 commented Jun 4, 2020

That's because they're totally separate things currently, will be fixed by #2907

@micah-k
Copy link

micah-k commented Jun 9, 2020

I personally use this functionality if the itch strikes me to listen to a different song in the middle of my current playlist; merging the players will force me to either stop my current playlist entirely for that single song, or open the playlist and spend the time to slowly drag the new song up to the next play spot. Fixing this "issue" will actually remove functionality from the app for no discernible reason.

@theFireProject
Copy link
Author

theFireProject commented Jun 10, 2020

I personally use this functionality if the itch strikes me to listen to a different song in the middle of my current playlist; merging the players will force me to either stop my current playlist entirely for that single song, or open the playlist and spend the time to slowly drag the new song up to the next play spot. Fixing this "issue" will actually remove functionality from the app for no discernible reason.

You're talking about a different issue and there is a simple solution for your issue. It's a better way to address each issue directly instead of using the work-around you explained.
The standard and convenient solution to satisfy that itch in a media player is an option to add a song to the queue to be played next.

@theFireProject
Copy link
Author

I would prefer to be able to have multiple players at the same time. I may be listening to a playlist in background mode with the background player. Now I decide to take a break and watch a video outside of the background player - either in a popup player or full screen player while the background player is paused. When I finish watching this break video, I currently have the option to resume the background player and continue listening to the playback list where I left of without having to reload that list. Please don't disable the flexibility to use multiple players in NewPipe.

This is a similar thing to what @micah-k explained. The solution is a "play next" option to add a video to the playback queue. If you want to watch a video in full-screen mode you can still do this because you cannot edit the a playlist in full-screen mode so this can be independent from the both modes that can play videos in the background.

@MD77MD
Copy link

MD77MD commented Jun 23, 2020

This issue will be solved once the development of (#2907 Expandable player with unified UI) is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants