Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback positions aren't synchronized for stream when foreground and/or background and/or popup player are opened at the same time or switched #3888

Closed
vkay94 opened this issue Jul 15, 2020 · 1 comment · Fixed by #2907
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@vkay94
Copy link
Contributor

vkay94 commented Jul 15, 2020

Version

  • NewPipe Version 19.6 (official)

Steps to reproduce the bug

  1. Open any video in details view (tested with YouTube)
  2. Press the buttons for background playback and popup player (+ optionally on the video itself to open the main player)
  3. Keep the video playing or seek to any position in popup player/main player

Expected behavior

There are actually two different expections depending on whether the app should allow multiple instances for a single stream or not:

  • If the three player types are allowed to be open simultaneously: The current position should be shared/synchronized between all players, so when it is switched (e.g. popup player => main player) the video should resume at the latest position.
  • If not allowed: The previous player type should close and the other player should resume at its last position.

Actual behaviour

The current position is not synchronized, so your current progress is not saved when switching the type.

Screenshots/Screen recordings

@vkay94 vkay94 added the bug Issue is related to a bug label Jul 15, 2020
@vkay94 vkay94 changed the title Playback positions aren't synchronized for stream when foreground and/or background and/or popup player are opened at the same time Playback positions aren't synchronized for stream when foreground and/or background and/or popup player are opened at the same time or switched Jul 15, 2020
@Stypox Stypox added the player Issues related to any player (main, popup and background) label Jul 15, 2020
@Stypox Stypox linked a pull request Jul 15, 2020 that will close this issue
@wb9688
Copy link
Contributor

wb9688 commented Jul 15, 2020

Those players are completely separate and this will be solved by #2907

@wb9688 wb9688 closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants