Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video player option from preferred open action (open in fullscreen) #4070

Closed
wb9688 opened this issue Aug 4, 2020 · 7 comments · Fixed by #4259
Closed

Fix video player option from preferred open action (open in fullscreen) #4070

wb9688 opened this issue Aug 4, 2020 · 7 comments · Fixed by #4259
Assignees
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@wb9688
Copy link
Contributor

wb9688 commented Aug 4, 2020

Version

Steps to reproduce the bug

  1. In audio-video settings, set "video player"
  2. Open a video (from an external url?)

Expected behavior

It open the video in fullscreen, either portrait (vertical video) or landscape mode (horizontal video).

Actual behaviour

It open the video just like "Show info" would do.

Additional note

"Video player" should be renamed to fullscreen ~ or something like that
People which have chosen "Video player" in settings should have fullscreen ~ preference selected

@wb9688 wb9688 added the feature request Issue is related to a feature in the app label Aug 4, 2020
@B0pol
Copy link
Member

B0pol commented Aug 4, 2020

It should open the video in fullscreen IMO, because that's what people wanted when choosing video player.

@B0pol B0pol added the GUI Issue is related to the graphical user interface label Aug 4, 2020
@ghost
Copy link

ghost commented Aug 4, 2020

I have something I wanna say.

I always have the need to check the thumbnail. Currently 0.19.8 I can click a video and see the thumbnail clear and big. Now using the Unified Player I have always brought myself back to 0.19.8... I kinda miss looking at the thumbnail before I watch the video. Sometimes I don't want to watch the video but check the thumbnail or just read the comments. :)

@opusforlife2
Copy link
Collaborator

@ingingin Just turn off Autoplay in Video settings. This option was added by the same PR. ;)

@TobiGr TobiGr self-assigned this Aug 15, 2020
@opusforlife2
Copy link
Collaborator

It should open the video in fullscreen IMO, because that's what people wanted when choosing video player.

And the string should be changed to convey that instead.

@B0pol B0pol changed the title Remove pointless video player option from preferred open action Fix video player option from preferred open action (open in fullscreen) Aug 17, 2020
@opusforlife2
Copy link
Collaborator

#4071 (comment) pasted here unchanged:

Ok, wait, I just tested with the Always Ask option in the latest debug apk. Both Show Info and Video Player have the exact same behaviour for autoplay off: they open the video details but don't play it. For autoplay on, both open video details, and the video additionally plays if Video Player was selected.

Now, I think a better solution than my comment above is to tweak the behaviour in this way:

  • if autoplay is off, the app should show Show Info as an option, but hide Video Player. (or grey it out)
  • if autoplay is on, the app should show Video Player as an option, but hide Show Info. (or grey it out)

This ^ is for the Always Ask dialog when opened externally, and for the Preferred open action dialog in Settings. Moreover if Video Player is selected as the preferred open action, then turning autoplay off should replace it with Show Info, but keep that radio button selected, and vice versa.

I think this set of behaviours will be the most intuitive.

@opusforlife2
Copy link
Collaborator

Also, avently's investigation for context: #4071 (comment)

@gbakeman
Copy link

gbakeman commented Oct 29, 2020

I see the issue is closed, was this bug fixed? My player still opens to the info screen (non-fullscreen) when opening a link with the Video player option, unlike before when it would directly open the video fullscreen.

Edit: Current version is 0.20.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
5 participants