Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play all" button in lists misbehaves when something is already playing #4843

Closed
4 tasks done
Stypox opened this issue Nov 8, 2020 · 2 comments
Closed
4 tasks done
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@Stypox
Copy link
Member

Stypox commented Nov 8, 2020

Checklist

Steps to reproduce the bug

  • enqueue a random video in the background
  • open a local playlist, a remote playlist, a channel or the history fragment
  • tap on "Play all"

Actual behaviour

The video details of the first item of the list are shown without starting the main player and the rest of the queue is not preserved

Expected behavior

The main player should start playing right away and the already-playing queue should be completely replaced by the whole list (see #4562)

@Stypox Stypox added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Nov 8, 2020
@LargePrime
Copy link

Yep, crash

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Country: CA
  • Content Language: en-CA
  • App Language: en_CA
  • Service: none
  • Version: 0.20.2
  • OS: Linux Android 9 - 28
Crash log

java.lang.RuntimeException: Unable to start service org.schabi.newpipe.player.MainPlayer@720b36b with Intent { cmp=org.schabi.newpipe/.player.MainPlayer (has extras) }: java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.player.playqueue.PlayQueueItem.getServiceId()' on a null object reference
	at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3821)
	at android.app.ActivityThread.access$1800(ActivityThread.java:207)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1779)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6863)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:537)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.player.playqueue.PlayQueueItem.getServiceId()' on a null object reference
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment.onQueueUpdate(VideoDetailFragment.java:1736)
	at org.schabi.newpipe.player.helper.PlayerHolder$2.onQueueUpdate(PlayerHolder.java:181)
	at org.schabi.newpipe.player.VideoPlayerImpl.updateQueue(VideoPlayerImpl.java:1982)
	at org.schabi.newpipe.player.VideoPlayerImpl.initPlayback(VideoPlayerImpl.java:714)
	at org.schabi.newpipe.player.BasePlayer.handleIntent(BasePlayer.java:376)
	at org.schabi.newpipe.player.VideoPlayer.handleIntent(VideoPlayer.java:273)
	at org.schabi.newpipe.player.VideoPlayerImpl.handleIntent(VideoPlayerImpl.java:235)
	at org.schabi.newpipe.player.MainPlayer.onStartCommand(MainPlayer.java:127)
	at android.app.ActivityThread.handleServiceArgs(ActivityThread.java:3802)
	... 8 more


@litetex
Copy link
Member

litetex commented Feb 26, 2022

Works as expected on 0.22.0

@litetex litetex closed this as completed Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants