-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SonarQube] Follow up to Sonar analyzing old branches #5926
Comments
@TobiGr So yes? 🙏 |
Can we re-enable SonarQube then? Would certainly help finding issue like this one (although it's in the Extractor it can also happen here): |
Obligatory quaterly ping to @TobiGr to active it or give me rights to do it. |
Sorry, @XiangRongLin. You should be able to edit the settings now |
@TobiGr I don't have access to activate the sonarcloud integration under: https://github.com/TeamNewPipe/NewPipe/settings/installations Can you do it? |
Done |
This addresses #5906
I looked into it and it looks like the analyisis is getting resubmitted after a PR is merged. So those are not old PR, but a duplicate.
Take: https://sonarcloud.io/dashboard?id=TeamNewPipe_NewPipe&pullRequest=215
If you take a look at the new lines, meaning what changed, you can see that it were changes from the 24. March: https://sonarcloud.io/code?id=TeamNewPipe_NewPipe&pullRequest=215&selected=TeamNewPipe_NewPipe%3Asrc%2Fmain%2Fjava%2Forg%2Fschabi%2Fnewpipe%2Futil%2FThemeHelper.java&line=172
I have no idea why this occurs and how to solve it. But i also don't see a problem, since the branches will get deleted after 30 days of inactivity.
So I would say we can enable sonar again.
@TobiGr
The text was updated successfully, but these errors were encountered: