Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SonarQube] Follow up to Sonar analyzing old branches #5926

Closed
XiangRongLin opened this issue Mar 27, 2021 · 6 comments
Closed

[SonarQube] Follow up to Sonar analyzing old branches #5926

XiangRongLin opened this issue Mar 27, 2021 · 6 comments
Labels
meta Related to the project but not strictly to code

Comments

@XiangRongLin
Copy link
Collaborator

This addresses #5906

I looked into it and it looks like the analyisis is getting resubmitted after a PR is merged. So those are not old PR, but a duplicate.
Take: https://sonarcloud.io/dashboard?id=TeamNewPipe_NewPipe&pullRequest=215
If you take a look at the new lines, meaning what changed, you can see that it were changes from the 24. March: https://sonarcloud.io/code?id=TeamNewPipe_NewPipe&pullRequest=215&selected=TeamNewPipe_NewPipe%3Asrc%2Fmain%2Fjava%2Forg%2Fschabi%2Fnewpipe%2Futil%2FThemeHelper.java&line=172

I have no idea why this occurs and how to solve it. But i also don't see a problem, since the branches will get deleted after 30 days of inactivity.

So I would say we can enable sonar again.

@TobiGr

@XiangRongLin XiangRongLin added the meta Related to the project but not strictly to code label Mar 27, 2021
@XiangRongLin
Copy link
Collaborator Author

@TobiGr So yes? 🙏

@litetex
Copy link
Member

litetex commented Aug 28, 2021

Can we re-enable SonarQube then?

Would certainly help finding issue like this one (although it's in the Extractor it can also happen here):
TeamNewPipe/NewPipeExtractor#709 (comment)

@XiangRongLin
Copy link
Collaborator Author

Obligatory quaterly ping to @TobiGr to active it or give me rights to do it.

@TobiGr
Copy link
Contributor

TobiGr commented Dec 19, 2021

Sorry, @XiangRongLin. You should be able to edit the settings now

@XiangRongLin
Copy link
Collaborator Author

@TobiGr I don't have access to activate the sonarcloud integration under: https://github.com/TeamNewPipe/NewPipe/settings/installations

Can you do it?

@XiangRongLin XiangRongLin reopened this Dec 21, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Dec 21, 2021

Done

@TobiGr TobiGr closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

No branches or pull requests

3 participants