Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking videos as watched doesn’t work and causes the app to freeze #6987

Closed
4 tasks done
slavalamp opened this issue Aug 26, 2021 · 3 comments
Closed
4 tasks done
Labels
bug Issue is related to a bug

Comments

@slavalamp
Copy link

slavalamp commented Aug 26, 2021

Checklist

Steps to reproduce the bug

  1. Open a channel group
  2. Long press any video in the feed
  3. Press “Mark as watched”
  4. Try to go back (using the button in the app or the device back button)

Actual behavior

At Step 3 visually nothing happens, at Step 4 the app freezes and doesn’t react to any actions anymore. (If you close and reopen it, it goes back to normal)

Expected behavior

The video being marked as watched and the app not freezing and instead going back to the subscriptions page

Screenshots/Screen recordings

I can’t record a video right now, but I can add it in a few days if needed

Logs

Device info

  • Android version/Custom ROM version: Android 8.0.0
  • Device model: Samsung Galaxy A3 (2017) / SM-A320F
@slavalamp slavalamp added the bug Issue is related to a bug label Aug 26, 2021
@nschulzke
Copy link
Contributor

I never found this with "Mark as Watched" on the feed views, but I ran into it when trying to extend Mark as Watched to other pages. I made a fix in PR #7160 that replaces a call to getState(streamId).blockingFirst() with a simpler upsert(), which fixed it for the other views. I can't be sure it'll fix your case (since I'm not seeing what you're seeing), but it's likely that it will.

@opusforlife2
Copy link
Collaborator

@janTaja Is your issue fixed?

@slavalamp
Copy link
Author

I think so, I haven't encountered it in a very long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants