Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.21.11 #7193

Closed
TobiGr opened this issue Oct 2, 2021 · 14 comments
Closed

Release 0.21.11 #7193

TobiGr opened this issue Oct 2, 2021 · 14 comments

Comments

@TobiGr
Copy link
Contributor

TobiGr commented Oct 2, 2021

Testing APK

NewPipe_v0.21.11_RC1.zip
Corresponding PR #7192

Changelog

App

New

3 - Add a play next button to the long press menu #6872
11 - Add YouTube shorts path prefix to intent filter #7181

Improved

17 - Swap seekbar position with player buttons in Queue screen #6824
4 - Make all buttons in player have selectable item background borderless #7042
13 - Expand minimized player buttons clickable area #7177
15 - Search for updates immediately when enabling automatic update checks on GitHub builds #6980

Fixed

8 - Fixed Settings import #7169
9 - Various fixes related to MediasessionManager #7166
10- Disabled media tunneling on RealtekATV #7178
16 - Fixed seekbar not completed after video end #7176

Development

1 - Updated Android Gradle Plugin to version 7.0.2 #6974 ⚠️ Now requires Java 11 to build
2 - Allow passing in package name suffix through CLI #6420
5 - Extracted repeated variable to a constant #7132
6 - Removed deprecated preferenceTheme style attribute #7156
7 - Regenerated some drawables to their latest design #7152
12 - Updated Groupie library to 2.9.0 #7150
14 - Fixed typos in READMEs #7184

Extractor

New

Improved

Development

@TobiGr TobiGr mentioned this issue Oct 2, 2021
@tsiflimagas
Copy link
Contributor

There are two issues which were introduced after 0.2.10 was merged into dev (at least as far as I noticed), and were present only in dev by then (they're not present in 0.2.10 release).

  1. Tapping on timestamps in comments, starts the video in paused popup player, though it should continue playing right away.
  2. Partially watched videos never start from the point where they were left at, they always start from the beginning.

@ghost
Copy link

ghost commented Oct 2, 2021

My English is in progress, so I'm not sure, but wouldn't it be better if in the long press menu the "Enqueue next" was "Enqueue as next"

To me "Enqueue next" would mean to queue the next video, which makes no sense.

enqueue

@triallax
Copy link
Contributor

triallax commented Oct 2, 2021

@CloverBadland "Enqueue next" is entirely valid and idiomatic English as far as I know. Here "next" is used as an adverb. It's like saying "play next"; this would be typically interpreted as "play this next" and not as "play the next video." I'm welcome to be proven wrong though, as I'm not a linguist.

@triallax triallax pinned this issue Oct 2, 2021
@litetex

This comment has been minimized.

@Redirion
Copy link
Member

Redirion commented Oct 5, 2021

2. Partially watched videos never start from the point where they were left at, they always start from the beginning.

could this be a regression from #7176?

@TobiGr
Copy link
Contributor Author

TobiGr commented Oct 5, 2021

@Redirion yes, we should also check whether the duration and current position are different by less than 1 second before setting the current position to the duration

@tsiflimagas
Copy link
Contributor

Both of the mentioned regressions were introduced a bit earlier than 0.2.10 release, but I couldn't notice which was the commit which did any of the two, since I only noticed them after 0.2.10 branch was merged in dev. #7176 is newer than that. The regression may lies to the code there, but I think it's not related to this commit.

@Mhowser
Copy link

Mhowser commented Oct 8, 2021

I'm not sure how to view the comment replies on Youtube, or is that not implemented in the frontend yet?

@triallax
Copy link
Contributor

triallax commented Oct 8, 2021

@Mhowser indeed, that hasn't been implemented in the app yet. PRs welcome!

@ghost
Copy link

ghost commented Oct 9, 2021

@Mhowser indeed, that hasn't been implemented in the app yet. PRs welcome!

I'm sorry for offtop, just one question.

@FireMasterK Maybe you planned to add comment replies in the frontend (app)? Or someone else should do that? Just for the information. Thanks in advance for the answer!

@FireMasterK
Copy link
Member

I'm sorry for offtop, just one question.

@FireMasterK Maybe you planned to add comment replies in the frontend (app)? Or someone else should do that? Just for the information. Thanks in advance for the answer!

I had no such intentions. You or anyone else is free to implement it!

@TobiGr
Copy link
Contributor Author

TobiGr commented Oct 10, 2021

2. Partially watched videos never start from the point where they were left at, they always start from the beginning.

could this be a regression from #7176?

I just checked this. This bug also exists in the current release. So this is not a blocker.

@TobiGr TobiGr closed this as completed Oct 11, 2021
@TobiGr TobiGr unpinned this issue Oct 11, 2021
@tsiflimagas
Copy link
Contributor

@TobiGr hmm weird, I can't reproduce it on v0.20.10. Anyway, I guess I'll open issues for each of the mentioned problems, so they can be tracked down.

@tsiflimagas
Copy link
Contributor

@Redirion I found the source of both the regressions I mentioned. It's the changes made by #6872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants