-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.21.11 #7193
Comments
There are two issues which were introduced after 0.2.10 was merged into dev (at least as far as I noticed), and were present only in dev by then (they're not present in 0.2.10 release).
|
@CloverBadland "Enqueue next" is entirely valid and idiomatic English as far as I know. Here "next" is used as an adverb. It's like saying "play next"; this would be typically interpreted as "play this next" and not as "play the next video." I'm welcome to be proven wrong though, as I'm not a linguist. |
This comment has been minimized.
This comment has been minimized.
could this be a regression from #7176? |
@Redirion yes, we should also check whether the duration and current position are different by less than 1 second before setting the current position to the duration |
Both of the mentioned regressions were introduced a bit earlier than 0.2.10 release, but I couldn't notice which was the commit which did any of the two, since I only noticed them after 0.2.10 branch was merged in dev. #7176 is newer than that. The regression may lies to the code there, but I think it's not related to this commit. |
I'm not sure how to view the comment replies on Youtube, or is that not implemented in the frontend yet? |
@Mhowser indeed, that hasn't been implemented in the app yet. PRs welcome! |
I'm sorry for offtop, just one question. @FireMasterK Maybe you planned to add comment replies in the frontend (app)? Or someone else should do that? Just for the information. Thanks in advance for the answer! |
I had no such intentions. You or anyone else is free to implement it! |
I just checked this. This bug also exists in the current release. So this is not a blocker. |
@TobiGr hmm weird, I can't reproduce it on v0.20.10. Anyway, I guess I'll open issues for each of the mentioned problems, so they can be tracked down. |
Testing APK
NewPipe_v0.21.11_RC1.zip
Corresponding PR #7192
Changelog
App
New
3 - Add a play next button to the long press menu #6872
11 - Add YouTube shorts path prefix to intent filter #7181
Improved
17 - Swap seekbar position with player buttons in Queue screen #6824
4 - Make all buttons in player have selectable item background borderless #7042
13 - Expand minimized player buttons clickable area #7177
15 - Search for updates immediately when enabling automatic update checks on GitHub builds #6980
Fixed
8 - Fixed Settings import #7169
9 - Various fixes related to MediasessionManager #7166
10- Disabled media tunneling on RealtekATV #7178
16 - Fixed seekbar not completed after video end #7176
Development
1 - Updated Android Gradle Plugin to version 7.0.2 #6974⚠️ Now requires Java 11 to build
2 - Allow passing in package name suffix through CLI #6420
5 - Extracted repeated variable to a constant #7132
6 - Removed deprecated preferenceTheme style attribute #7156
7 - Regenerated some drawables to their latest design #7152
12 - Updated Groupie library to 2.9.0 #7150
14 - Fixed typos in READMEs #7184
Extractor
New
Improved
Development
The text was updated successfully, but these errors were encountered: