Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pitch black theme #8110

Open
5 tasks done
triallax opened this issue Mar 26, 2022 · 8 comments
Open
5 tasks done

Add a pitch black theme #8110

triallax opened this issue Mar 26, 2022 · 8 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people

Comments

@triallax
Copy link
Contributor

triallax commented Mar 26, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Add a pitch black theme where most UI elements are black. The current black theme should remain unchanged.

Why do you want this feature?

Some people think it looks better.

Additional information

I'm aware that #4148 exists, please read #4148 (comment) to learn why this is not a duplicate.

See polymorphicshade#167 for some prior work on this.

@triallax triallax added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Mar 26, 2022
@SameenAhnaf
Copy link
Collaborator

#7846 (comment) suggests an option how to indicate the service. Service colour should not be necessarily shown on top bar.

@litetex litetex added the niche Only relevant to a very small amount of people label Mar 26, 2022
@rahaaatul
Copy link

rahaaatul commented Mar 27, 2022

Here is the color scheme

GitHub Dark

Background: #0D1117
Surface: #161B22
Accent: #58A6FF
Hint: #30363D

Screenshots

Screenshot_20220324160748.jpg

Screenshot_20220324160907.jpg - Screenshot_20220324161042.jpg - Screenshot_20220324161102.jpg - Screenshot_20220324163006.jpg - Screenshot_20220324163334.jpg

Pulled Request in polymorphicshade#167. You need to change switch color to accent color in settings. There's no way to change that in colors.xml.

@jojobozo
Copy link

jojobozo commented Mar 27, 2022

Really nice theme, will you keep updating it if they don't accept your request?

Mod note: Don't just quote a giant comment. Look for the relevant portion.

@rahaaatul
Copy link

nice theme, will you keep updating it if they don't accept your request?

If they don't do it, I'll keep updating it on my fork. Although I can just change the color. If I knew to code, I'd added this theme a long time ago.

@jojobozo
Copy link

jojobozo commented Mar 27, 2022

Nice thanks for the reply

@ghost
Copy link

ghost commented Apr 3, 2022

Everyone is mislead that dark mode (greyish black) will not save the battery life. Here's the research of that by an XDA dev.
Infact dark mode saves your eyes compared to pitch black, from unreadability & long term eye strain.

@flickenschild
Copy link

Problem: The original Theme had a red bar below each video that would show when the video was previously started or watched. It would mark the progression in the video or would show a full red bar when completely watched. That bar is now also pitch black so no telling whether you watched a video or not!

@triallax
Copy link
Contributor Author

@flickenschild not every single UI element will be made black of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface niche Only relevant to a very small amount of people
Projects
None yet
Development

No branches or pull requests

6 participants