Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a loop/replay button #8647

Open
5 tasks done
theridon opened this issue Jul 17, 2022 · 8 comments
Open
5 tasks done

Add a loop/replay button #8647

theridon opened this issue Jul 17, 2022 · 8 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) rewrite Issues and PRs related to rewrite

Comments

@theridon
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

This app has just about everything else, it's great. But for some reason there is no replay/loop button/functionality? Can we just get a simple button below the video that would let it replay videos, such as for listening to music in a car? Thank you.

Why do you want this feature?

So the app is better

Additional information

No response

@theridon theridon added the feature request Issue is related to a feature in the app label Jul 17, 2022
@SameenAhnaf
Copy link
Collaborator

Rejected. See: #6914

However, you can still use this functionality from notification player. Go to Settings>Appearence>Player Notification>4th/ 5th Action Button> Select Repeat

@theridon
Copy link
Author

I disable notifications from my apps, so I can't use that feature. Plus it's quite inconvenient to have to drag down the notification bar for such a basic, integral feature. Can we just get a button that's usable when normally using the app?

@opusforlife2
Copy link
Collaborator

I disable notifications from my apps

In version 0.20.0, Newpipe's player was rewritten and made wholly dependent on a unified player service, which needs a foreground notification to anchor it in memory.

I don't think we support use cases where notifications for the app are disabled. But I'll let a developer weigh in on this.

@triallax
Copy link
Contributor

I wholeheartedly agree that it doesn't make sense for the looping functionality to be present only in the media notification, not the app itself. It's quite inconvenient. Like I stated in #6914 (comment), adding a loop button in the player would be a good idea in my opinion.

@Stypox
Copy link
Member

Stypox commented Jul 22, 2022

I don't think we support use cases where notifications for the app are disabled. But I'll let a developer weigh in on this.

Foreground apps work just fine if you disable their notifications ;-)

@opusforlife2
Copy link
Collaborator

I agree with Stypox's solution in #6914 (comment).

@opusforlife2 opusforlife2 added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Jul 25, 2022
@opusforlife2
Copy link
Collaborator

This is something that should be considered for the rewrite.

@ShareASmile ShareASmile added the rewrite Issues and PRs related to rewrite label Oct 23, 2024
@merlin555

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) rewrite Issues and PRs related to rewrite
Projects
Status: Todo
Development

No branches or pull requests

7 participants