Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast notification when an update is available #9192

Open
6 tasks done
killerrook opened this issue Oct 24, 2022 · 6 comments
Open
6 tasks done

Toast notification when an update is available #9192

killerrook opened this issue Oct 24, 2022 · 6 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@killerrook
Copy link

killerrook commented Oct 24, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Toast notification when an update is available upon opening the app. A message like 'new updates found check notifications' or something similar when check for updates is performed and a new version is found

Why do you want this feature?

Notifications can be accidentally cleared when there are a lot of notification stacked up by just one clear notification button offered by most ROMs which could lead to users missing out on an update. Most users are not even bothered to check notifications most of the time. It could even coerce the user to manually check for updates on github or somewhere else.

Additional information

No response

@killerrook killerrook added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 24, 2022
@opusforlife2 opusforlife2 added GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels Oct 24, 2022
@SameenAhnaf
Copy link
Collaborator

Is this different from #9175?

@killerrook
Copy link
Author

killerrook commented Oct 24, 2022

Combined both closing #9175 to avoid somewhat similar issues
Yes it is different #9175 deals with manual check for updates it deals with both manual and automatic check for updates.

@opusforlife2
Copy link
Collaborator

The manual check part is not needed. There is already a PR for that.

@killerrook
Copy link
Author

killerrook commented Oct 24, 2022

Should I edit the manual part or should I keep it just in case of better context? Yup there is a pr already #8668 for manual part

@opusforlife2
Copy link
Collaborator

Remove the manual part.

@killerrook
Copy link
Author

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants