New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expectation for generated typings file #44

Open

spjtls9 opened this issue Dec 7, 2020 · 1 comment

spjtls9 commented Dec 7, 2020

Hi-

First of all, thanks for the fork - it is very helpful to have an active repo for this.

Question:

Am I supposed to check in the generated typings file to source control?

There is this issue in the old repo: Jimdo/typings-for-css-modules-loader#79 (comment)
And without checking in the typings files, the same issue will happen.

Is there any known issues with checking in the typings file?

monic-shixi commented Dec 27, 2020

Hi-

First of all, thanks for the fork - it is very helpful to have an active repo for this.

Question:

Am I supposed to check in the generated typings file to source control?

There is this issue in the old repo: Jimdo/typings-for-css-modules-loader#79 (comment)
And without checking in the typings files, the same issue will happen.

Is there any known issues with checking in the typings file?

Yep, maybe the https://github.com/TeamSupercell/typings-for-css-modules-loader#typescript-does-not-find-the-typings and you are used fork-ts-checker-webpack-plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment