Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poorly-handled case of results.zip when no results.json came before it #11

Closed
michaelhixson opened this issue Feb 15, 2019 · 1 comment

Comments

@michaelhixson
Copy link
Contributor

If you upload a results.zip file to tfb-status but you never uploaded a results.json for that same run before, tfb-status handles that situation poorly. In terms of sorting on the home page, the run is placed last instead of first. Also, the environment name and other details don't show up for that run on the home page or results detail page.

The sorting behavior is an accident of how the sort order for home page entries is defined in code. The environment name (and other details) not showing up is because that rendering code is trying to pull those attributes from the standalone results.json file only and not looking in the results.zip file (which also contains a perfectly usable results.json file inside).

@michaelhixson
Copy link
Contributor Author

Reopening because I fixed the sorting but not this part:

Also, the environment name and other details don't show up for that run on the home page or results detail page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant