Memory Leaking Problems

[jxsl13]

Some commands, even player accessible ones like /top seem to cause memory leaks. Something seems not to be cleaned.

Also some free() function calls seem to be weirdly placed in the ranking system functions.

[Teelevision]

I can imagine. PRs are welcome.

[jxsl13]

zcatch/src/game/server/gamemodes/zcatch.cpp

Line 429 in 9adb5b0

GameServer()->AddRankingThread(new std::thread(&CGameController_zCatch::SaveScore,

zcatch/src/game/server/gamecontext.h

Line 95 in 9adb5b0

std::vector<std::thread*> m_RankingThreads;

zcatch/src/game/server/gamecontext.h

Line 241 in 9adb5b0

void AddRankingThread(std::thread *thread) { m_RankingThreads.push_back(thread); };

zcatch/src/game/server/gamecontext.cpp

Lines 75 to 99 in 9adb5b0

	CGameContext::~CGameContext()
	{
	/* ranking db */
	/* wait for all threads */
	for (auto &thread: m_RankingThreads)
	{
	thread->join();
	delete thread;
	}
	for(int i = 0; i < MAX_CLIENTS; i++)
	delete m_apPlayers[i];
	if (!m_Resetting)
	{
	delete m_pVoteOptionHeap;
	/* close ranking db */
	if (RankingEnabled())
	{
	sqlite3_close(m_RankingDb);
	}
	}
	}

I think it should be possible to somehow delete the allocated memory of the threads before the destruction of the actual GameContext. It's possible to spam "/top", which spawns endless threads, which are already finished executing, but the thread handles are still in memory.
I don't know when exactly the GameContext is destroyed, but I suppose it's when the server is shutdown.

[jxsl13]

The solution would be to remove the vector, the AddRankingThread() function and replace every usage of said function with
std::thread *t = new std::thread(&...);
t->detach();
delete t;

and delete the part in the destructor.

[jxsl13]

/*thread stuff*/
	std::vector<std::thread*> m_Threads;

	void AddThread(std::thread *thread) { m_Threads.push_back(thread); };
	void CleanThreads() {
		while (!m_Threads.empty()) {
			std::thread *t = m_Threads.back();
			t->join();
			delete t;
			m_Threads.pop_back();
		} ;
	};

Put this into Tick and in either OnShutDown or in the Destructor:

if (Tick % (50 * 5) == 0) {
				CleanThreads();
			}

Detached threads are hard to control, thus better keep joining them every 5 seconds, when they are done writing to the DB.