New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PyShExC to generate shapes in JSON-LD #18

Closed

Teester opened this issue Nov 22, 2021 · 0 comments · Fixed by #20

Assignees

Labels

backend enhancement

Owner

Teester commented Nov 22, 2021

Use PyShExC (https://github.com/shexSpec/grammar-python-antlr) to generate shapes in JSON-LD, which is a standard, rather than the bespoke json we are currently generating.

Advantages:

will translate parts of shemas that we currently do not, such as AND and OR, making it easier to solve Add support for lexemes #1, Add support for groups #2 and Add support for "or" #3
can let PyShExC worry about generating json shapes rather than supporting it here
adheres to a standard, which may make reuse easier

Disadvantages:

requires rewriting compareshape.py to parse JSON-LD instead of the current json.

Teester added enhancement backend labels

Teester self-assigned this

Teester mentioned this issue

Use json-ld rather than custom calculation of shape #20

Merged

Teester linked a pull request

that will close this issue

Use json-ld rather than custom calculation of shape #20

Merged

Teester closed this as completed in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment