Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BfA update please? #27

Open
bronze opened this issue Aug 15, 2018 · 20 comments
Open

BfA update please? #27

bronze opened this issue Aug 15, 2018 · 20 comments

Comments

@bronze
Copy link

bronze commented Aug 15, 2018

I've been using this for so long! Its a must-have!

@bronze
Copy link
Author

bronze commented Aug 16, 2018

hpot: 152494 163082
mpot: 152495 163082

food:
155811 163133 163118 163117 159869 159870 159871 163109 159873 163107 159875 163105 159878 163100 159897 163083 159899 159900 163061 163058 163054 160518 163053 162582 162568 162567 162564 162563 161346 162561 162559 162558 161383 162556 162546 162550 155812 160554 162555 162557 161373 161348 161347 162562 161128 161127 162565 162566 161126 160989 160611 163050 163051 163052 162545 160483 163056 159920 163060 159919 163075 163076 163077 159898 159879 159876 159874 159872 163115 158926 158466 162554
154889 154891

water:
163786 159868 162570 163784 163785 158926 163076 163077 159867 163102 163104 163115 163783 162547 162569 163101
154889 154891

i dont know how you ordered it so these might not work as intended

*edit: forgot cooking foods, 2 of them that dont give the well fed buff

@liberoj
Copy link

liberoj commented Aug 19, 2018

If you have any documentation around the structure of the database file (specifically what do the different lines of values infer) one of us may fork this and pick it up.

@clarklwilliamson
Copy link

For the database values, the first entry is a index number, the higher the number the better it is.
The second set of numbers on one line, are all the item ids that match, and are equal.
That is my impression, after spending a few minutes looking at the code.

@liberoj
Copy link

liberoj commented Aug 20, 2018

That would make sense; However.. check out the database under lines 114 & 115. Wonder if the first number references stats provided by that item as well as the HP/MP restored. I'll keep looking on WoWHead for info.

@clarklwilliamson
Copy link

I couldn't find any correlation between the number that was there and the amount restored.
Some are 4% health regen which led me to believe that the awesome developer, (which he is, I love his addons), didn't bother with that number, because he doesn't need to.

@bronze
Copy link
Author

bronze commented Sep 2, 2018

i have edited the database file and been using this during this time, and found no errors so far. havent tested all foods though, just picked the biggest regen and went with it (oops)

@clarklwilliamson i did do some tests changing the position of the food's id and it kept showing my best one. my guess is the addon itself checks what is the best regen, perhaps?

@cpresse
Copy link

cpresse commented Oct 13, 2018

Hy there, the first number per line was the amount of health/mana given before the numbers were reduced.
So in the current version with all the food in one line with the first number 3600000 the addon thinks, all the food gives the same amount. Either we overwork the file with growing rankings of the new bfa food/drinks or we redo all the indexes with the actual values.

@cpresse
Copy link

cpresse commented Oct 14, 2018

I did the food part, maybe some of you can check it out? Works with actual wowhead numbers now

DB("food", [[
76 11109 6299
83 117 16166 17344 19223 2070 20857 23495 2679 2681 30816 4536 4540 4604 4656 5057 60267 60268 60375 60377 60378 60379 6290 7097 787 961 140337
233 12238 16167 17119 17406 18633 19304 2287 24072 414 4537 4541 4592 4605 49600 5066 5095 62909 6316 6316 67230 6890 112095
272 2682 5473
293 16170 19305 2685 3770 422 4538 4542 4593 4606 5478 5526 57518 63693 65730 65731 7228 733 140753 140754
1115 13755 16169 1707 17407 18632 19224 3771 4539 4544 4594 4607 61383 63692 6807 8364
1218 13546 13893 13930 16168 16766 17408 18255 18635 19306 21030 21552 3927 4599 4601 4602 4608 63691 6887
1885 23160
2284 13724
2419 11415 11444 13933 13935 19225 21031 21033 22324 24338 67270 67271 67272 67273 8932 8948 8950 8952 8953 8957 140339
2765 32722
7119 19301
8287 75026 81175 81889 81917 81919 81922 82448 82450 83097 85504 86026 86057 86508 104196
8442 41751 24408 27661 27854 27855 27856 27857 27858 27859 28486 29393 29412 30458 30610 38427 140344 33443 33449 33451 33452 33454 35949 37252 40356 40358 40359 42428 42430 42432 42433 44608 44609 44749
11386 74641 81916 81918 81920 81921 82449 82451 88398 90135 75038 112449
12431 58258 58260 58262 58264 58266 58268 59228 59232 62676
13779 29394 29448 29449 29450 29451 29452 29453 30355 32685 32686 33048 33053 34780 38428
13781 34747 34759 34760 34761 35947 35948 35950 35951 35952 35953 38706 40202 41729 42429 42431 42434 42778 43087 44049 44071 44072 44607 44722 58276 58277 58278 58279 58280 59227 59231 140341
14839 111456 111544 115351 115352 115353 115354 115355 117454 117457 117469 117470 117471 117472 117473 117474 118050 118051 113290 113099 130259 128761
17079 58259 58261 58263 58265 58267 58269 62677
17878 132752 132753
18030 45932
32576 140626 128836 128837 128839 128843 128845 128848 136556 138285 138976 138977 138979 138980 138987 139344 140201 140202 140276 128763 140668 128849 143681
35756 133575 138983 138986 139398 140355
35757 136544 136545 136546 136547 136548 136549 136550 136551 136552 136553 136554 136555 136557 136558 136559 136560 140273 140275 138972 138973 138974 133893 133981 133979 133893 140184 140205 140206 140207 128764 128835 140286 140296 140297 140299 140300 140301 140302 140627 128838 140631 140679 141206 141207 141208 141212 141213 141214 128840 128844 128846 128847 128851 138290 138291 138978 139345
83128 158926
102606 163118 159870 163109 163107 159875 163105 159878 163100 163083 159900 163061 163058 163054 162564 162555 162557 161373 161348 161348 161347 162562 161128 161127 162565 162566 161126 163050 163051 163052 162545 159920 163060 159898 159876 159872 163115 162554
166257 163133 163117 159869 159871 159873 159897 159899 160518 163053 162582 162568 162567 162563 161346 162561 162559 162558 161383 162556 162546 162550 155812 160554 160989 160483 163056 159919 163075 163076 163077 159879 159874
]])

@cpresse
Copy link

cpresse commented Oct 14, 2018

@bronze @mcfungster @liberoj @clarklwilliamson
All done. Forked it: https://github.com/cpresse/Buffet

All database changes in there. Found a few false items and added bandages. Feel free to use it.

@TheSpanishInq
Copy link

Done some work in this. Removed the static database entirely. Instead scans bags for items and pulls the in-game amounts direct.

https://www.dropbox.com/s/pjk9734zw4in7ku/Buffet-8.0.0-20181118a.zip?dl=0

Needs more work, but hoping that it won’t need updates to the database any time a change occurs in game.

@oumu
Copy link

oumu commented Feb 7, 2019

Done some work in this. Removed the static database entirely. Instead scans bags for items and pulls the in-game amounts direct.

https://www.dropbox.com/s/pjk9734zw4in7ku/Buffet-8.0.0-20181118a.zip?dl=0

Needs more work, but hoping that it won’t need updates to the database any time a change occurs in game.

Link is dead, could you please update it?

@TheSpanishInq
Copy link

Link is dead, could you please update it?

Need to find a permanent home for this. A few tweaks to improve it:
https://www.dropbox.com/s/12iaxvaav3mu5hg/Buffet-8.1.0-20190412.zip?dl=0

@TheSpanishInq
Copy link

https://www.dropbox.com/s/a08vco4brrh7n4b/Buffet%208.1.5%20-%2020190524.zip?dl=0

Updated, fixing an issue with the tooltip window popping up all the time. Can anyone confirm whether this is accessible to anyone else, and if so does it actually work in game? If it works I'd be happy to have this used for the basis of an official update if such a thing happens.

@bronze
Copy link
Author

bronze commented Jun 6, 2019

@TheSpanishInq that is amazing. just upload as a fork on github dude.
ive quit wow (again) so i cant test it...

@HgAlexx
Copy link

HgAlexx commented Jun 15, 2019

Hi,
I had the same idea as @TheSpanishInq and did some work on it.
Everything available here: https://github.com/HgAlexx/Buffet

Left todo:

  • Some localizations, I've done only EN, FR and DE
  • Health/Mana over time untested (I don't have any item of that kind to test it)
  • More stabilization and improvements

@TheSpanishInq
Copy link

Fixed a few issues to make it stable. Will look next at optimising by searching only the bag that was updated, but for now it seems to be working and stable:

https://github.com/TheSpanishInq/Buffet

@HgAlexx
Copy link

HgAlexx commented Sep 4, 2019

Hello,

I just pushed support for classic if anyone is interested.
https://github.com/HgAlexx/Buffet

For now I've localized for: enUS, deDE, esES and frFR

Mostly stable but more tests welcome!

Of course it's still working on BFA (with localization for itIT).

@spiralofhope
Copy link

This won't work for Shadowlands due to a SetBackdrop issue:
https://github.com/Stanzilla/WoWUIBugs/wiki/9.0.1-Consolidated-UI-Changes#backdrop-system-changes

HgAlexx#8

However, @TheSpanishInq you don't have issues enabled.

@TheSpanishInq
Copy link

I'm afraid I made the decision (quite glad now) to rewrite based on a much simpler format.

https://www.curseforge.com/wow/addons/spinx-cookie

Wow, was I well ahead of the curve on preparing for Stat Squish. Seems to be working fine on the PTR if you're interested. To be honest, the issues in hte fork will be based on the older interface stuff that I didn't touch. If there is a solution for the original then it should be easy enough to apply the same to mine as I believe only the core lua and toc were updated (and the DB removed)

@HgAlexx
Copy link

HgAlexx commented Oct 6, 2020

This won't work for Shadowlands due to a SetBackdrop issue:
https://github.com/Stanzilla/WoWUIBugs/wiki/9.0.1-Consolidated-UI-Changes#backdrop-system-changes

HgAlexx#8

However, @TheSpanishInq you don't have issues enabled.

Hello,
I'll have a look at that as soon as possible.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants