Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HeaderView): add support for setting custom accessibility IDs #71

Merged
merged 2 commits into from
Jan 28, 2021
Merged

fix(HeaderView): add support for setting custom accessibility IDs #71

merged 2 commits into from
Jan 28, 2021

Conversation

jmbrocal
Copy link
Contributor

Hi folks!

QA requested in this ticket for adding some missing IDs of Loyalty screens. In this PR you will find an update of HeaderView so I can customise the accessibility ids later in Novum

Enjoy!

@jmbrocal jmbrocal requested review from a team, salavert, jmpg93 and victorpimentel and removed request for a team January 27, 2021 15:41
@jmbrocal jmbrocal marked this pull request as ready for review January 28, 2021 09:24
@jmbrocal jmbrocal merged commit 97a98cd into main Jan 28, 2021
@jmbrocal jmbrocal deleted the jmbrocal/header-accessibility-support branch January 28, 2021 09:27
tuentisre pushed a commit that referenced this pull request Jan 28, 2021
@semantic-release-bot
chore(release): 8.0.1 [skip ci]
059149b 
## [8.0.1](v8.0.0...v8.0.1) (2021-01-28)

### Bug Fixes

* **HeaderView:** add support for setting custom accessibility IDs and labels ([#71](#71)) ([97a98cd](97a98cd))
* **ListViewCell:** Add missing accessibility identifiers in ListViewCell ([#70](#70)) ([33e1c8c](33e1c8c))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 8.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

victorpimentel
victorpimentel reviewed Jan 28, 2021
View reviewed changes
Copy link
Contributor

@victorpimentel victorpimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@victorpimentel victorpimentel requested review from victorpimentel and removed request for victorpimentel January 28, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorpimentel victorpimentel victorpimentel left review comments

@jmpg93 jmpg93 jmpg93 approved these changes

@salavert salavert salavert approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmbrocal @tuentisre @salavert @victorpimentel @jmpg93