feat(Sheet): allow closing the sheet with the keyboard or a screen reader #1293
Conversation
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 4a15139. |
| <Placeholder /> | ||
| </Box> | ||
| </ResponsiveLayout> | ||
| {({modalTitleId}) => ( |
There was a problem hiding this comment.
This fixes the issue with the wrong paddings in the sheet's story: https://jira.tid.es/browse/WEB-2101
| /> | ||
|
|
||
| {({ modalTitleId }) => ( | ||
| <SheetBody modalTitleId={modalTitleId}> |
There was a problem hiding this comment.
Fixing wrong usages in snippets too, they should be using SheetBody instead of ResponsiveLayout
There was a problem hiding this comment.
Unrelated. Yayo asked me to update the buton's size in the callout
# [16.6.0](v16.5.0...v16.6.0) (2024-11-26) ### Features * **data-testid:** support for Callout, HighlightedCard, Hero, EmptyState and Headers ([#1296](#1296)) ([15b798c](15b798c)) * **Header, Cards, Hero, CoverHero:** improve a11y ([#1292](#1292)) ([cdcf2fc](cdcf2fc)) * **InfoSheet:** update styles and allow adding a button to the content ([#1294](#1294)) ([c4a0749](c4a0749)) * **Meter:** New component ([#1281](#1281)) ([1a061d8](1a061d8)) * **Sheet:** allow closing the sheet with the keyboard or a screen reader ([#1293](#1293)) ([42099fb](42099fb))
|
🎉 This PR is included in version 16.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue: Link
Note
In this PR I'm also fixing a wrong usage in the Sheet's story. It was using a ResponsiveLayout instead of SheetBody, and therefore causing issues with horizontal padding in large devices (https://jira.tid.es/browse/WEB-2101)