Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No DEBUG log even enable it by -l DEBUG #105

Closed
wangyoucao577 opened this issue Dec 4, 2019 · 2 comments
Closed

No DEBUG log even enable it by -l DEBUG #105

wangyoucao577 opened this issue Dec 4, 2019 · 2 comments
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@wangyoucao577
Copy link

When I want to see some DEBUG log from OSRM(e.g. osrm-extract, etc), I found that there's nothing output even I passed in -l DEBUG.

case logDEBUG:
#ifdef NDEBUG
break;
#endif

After check codes, I found that it will only be enabled by build with debug type in compiling time and pass in -l DEBUG in runtime. It's not a good idea for debugging. People also may want to see more logs for investigating some issues with release binary.

@wangyoucao577 wangyoucao577 self-assigned this Dec 4, 2019
@wangyoucao577 wangyoucao577 added the Bug Something isn't working label Dec 4, 2019
@wangyoucao577
Copy link
Author

Refer to Project-OSRM#3427 (comment), disable debug log at compile time is mostly for performance.

@wangyoucao577
Copy link
Author

I also did some performance benchmark for remove compile time debug log control, see Project-OSRM#3427 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant