Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to merge changes from katzer master branch? #29

Open
dherbe opened this issue Nov 2, 2017 · 8 comments
Open

Plans to merge changes from katzer master branch? #29

dherbe opened this issue Nov 2, 2017 · 8 comments

Comments

@dherbe
Copy link

dherbe commented Nov 2, 2017

Hi there,

Is it possible to let us know when this fork will merge the latest updates and new features from the original branch? Therefor allowing us to update the plugin from the Telerik App builder.

Thank you

@EddyVerbruggen
Copy link

Hi, is there any specific element that's missing in this fork? And what is stopping you from using the upstream repo?

Thanks for the clarification!

@dherbe
Copy link
Author

dherbe commented Nov 2, 2017

I've always used this plugin, installed and updated from the Plugins Marketplace.
I can use the upstream repo, but I'm guessing I will have to maintain further updates manually right?

@dherbe
Copy link
Author

dherbe commented Nov 2, 2017

Missing in this fork, are the new updates which include ability to have actions and inputs and other local notifications customisation.

@EddyVerbruggen
Copy link

OK, the problem is I'm not able to spend more than a few minutes on this task, so if you can confirm swapping out this fork for the upstream won't break your app then I'll happily merge the changes and you can swap back. Does that work for you?

@dherbe
Copy link
Author

dherbe commented Nov 2, 2017

Yes sure. I'll do it and let you know later then.
Thanks Eddy

@dherbe
Copy link
Author

dherbe commented Nov 2, 2017

Hey,
Just to let you know

It seems it might give a bit more work.

I've tried to install the plugin from the upstream repo and awkwardly I got something for the first since I use Telerik Platform.

image

@EddyVerbruggen
Copy link

Could be there's stuff in the archive that's blacklisted. .git folder or .DS_Store files. Just guessing..

@dherbe
Copy link
Author

dherbe commented Nov 2, 2017

Thanks for the tip but no, I don't see any of such folders or files in the archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants