Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean flag based media style handling #39

Open
Temzasse opened this issue Nov 15, 2022 · 0 comments · May be fixed by #42
Open

Fix boolean flag based media style handling #39

Temzasse opened this issue Nov 15, 2022 · 0 comments · May be fixed by #42
Assignees
Labels
bug Something isn't working

Comments

@Temzasse
Copy link
Owner

The recent changes to resolveMediaRangeQuery broke the case where you would want to have boolean flag based media conditions like this:

const isTablet = DeviceInfo().isTablet();

createStitches({
  media: {
    phone: !isTablet,
    tablet: isTablet,
  }
});

const Example = styled('View', {
  backgroundColor: 'red',
  '@tablet': {
    backgroundColor: 'blue',
  }
});

This feature should be added back.

One problem we need to figure out is what is the specificity order when both boolean flag based and range queries are used and they overlap, eg:

createStitches({
  media: {
    phone: !isTablet,
    tablet: isTablet,
    md: '(width >= 750px)',
    lg: '(width >= 1080px)',
    xl: '(width >= 1284px)',
    xxl: '(width >= 1536px)',
  }
});

If for example tablet and xl would be both used and the device would match both which one should overwrite the other?

const Example = styled('View', {
  backgroundColor: 'red',
  '@tablet': {
    backgroundColor: 'blue',
  },
  '@xl': {
    backgroundColor: 'yellow',
  }
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant