Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): textInput may throw IllegalStateException #2957

Merged
merged 3 commits into from
Feb 22, 2023
Merged

fix(android): textInput may throw IllegalStateException #2957

merged 3 commits into from
Feb 22, 2023

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Feb 22, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@iPel iPel requested a review from siguangli as a code owner February 22, 2023 03:55
@github-actions github-actions bot added framework: android size: s Denotes a PR that changes 10-99 lines labels Feb 22, 2023
@hippy-service
Copy link

hippy-service bot commented Feb 22, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Feb 22, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zoomchan-cxj zoomchan-cxj added the action(squash-merge) Squash and merge action label Feb 22, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) February 22, 2023 13:14
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Feb 22, 2023
@hippy-actions hippy-actions bot merged commit f46b9d8 into Tencent:master Feb 22, 2023
zoomchan-cxj pushed a commit that referenced this pull request Mar 14, 2023
@iPel @open-hippy @zoomchan-cxj
fix(android): textInput may throw IllegalStateException (#2957)
7e9271b 
* fix(android): textInput may throw IllegalStateException

* fix(android): textInput may throw IllegalStateException

---------

Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
zoomchan-cxj pushed a commit that referenced this pull request Mar 21, 2023
@iPel @open-hippy @zoomchan-cxj
fix(android): textInput may throw IllegalStateException (#2957)
ded1a57 
* fix(android): textInput may throw IllegalStateException

* fix(android): textInput may throw IllegalStateException

---------

Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
framework: android size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iPel @siguangli @zoomchan-cxj @open-hippy