Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): non flattened elements background color #3352

Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix(android): non flattened elements background color #3352

merged 2 commits into from
Jul 4, 2023

Conversation

siguangli
Copy link
Collaborator

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Jul 4, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 4, 2023

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli requested a review from ilikethese July 4, 2023 08:29
@siguangli siguangli merged commit 85b0d2f into Tencent:main Jul 4, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 4, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 4, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jul 4, 2023

⚠️ rebase-merge action execution failed, because of auto rebase and merge failed.

Please check the following details:

GraphQL: Can't disable auto-merge for this pull request. (disablePullRequestAutoMerge)

#help

@hippy-actions hippy-actions bot added action(rebase-merge): failed Rebase and merge action execution failed and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Jul 4, 2023
siguangli added a commit to siguangli/Hippy that referenced this pull request Jul 7, 2023
@siguangli @siguangli2018
fix(android): non flattened elements background color (Tencent#3352)
2d52510 
Co-authored-by: maxli <maxli@tencent.com>
@siguangli siguangli deleted the fix/backgroundColor branch July 10, 2023 09:09
zealotchen0 pushed a commit that referenced this pull request Jul 25, 2023
@siguangli @siguangli2018 @zealotchen0
fix(android): non flattened elements background color (#3352)
2a7402a 
Co-authored-by: maxli <maxli@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilikethese ilikethese ilikethese approved these changes

Assignees
No one assigned
Labels
action(rebase-merge): failed Rebase and merge action execution failed renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siguangli @ilikethese @siguangli2018