Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): sticky header not deleted from ControllerManager #3356

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Jul 5, 2023

may crash in vue2 when recreating view with same id

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

may crash in vue2 when recreating view with same id
@iPel iPel requested a review from siguangli as a code owner July 5, 2023 13:34
@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Jul 5, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 5, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jul 10, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jul 10, 2023
@siguangli siguangli added action(squash-merge) Squash and merge action and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Jul 10, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) July 10, 2023 03:31
@hippy-actions hippy-actions bot disabled auto-merge July 10, 2023 03:31
@hippy-actions hippy-actions bot enabled auto-merge (squash) July 10, 2023 03:31
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 10, 2023
@hippy-actions hippy-actions bot merged commit 48decb1 into Tencent:main Jul 10, 2023
siguangli added a commit to siguangli/Hippy that referenced this pull request Jul 14, 2023
…nt#3356)

may crash in vue2 when recreating view with same id

Co-authored-by: siguangli <siguangli@qq.com>
Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
zealotchen0 pushed a commit that referenced this pull request Jul 25, 2023
may crash in vue2 when recreating view with same id

Co-authored-by: siguangli <siguangli@qq.com>
Co-authored-by: OpenHippy <124017524+open-hippy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants