Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): rewrite animation module #3436

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Aug 8, 2023

BREAKING CHANGE: this commit is a breaking change! Animation related code needs to be checked!

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service
Copy link

hippy-service bot commented Aug 8, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added the size: xl Denotes a PR that changes 1000+ lines label Aug 8, 2023
@wwwcg wwwcg force-pushed the feat/animation branch 2 times, most recently from ba19d6e to 18b1e7e Compare August 9, 2023 09:29
BREAKING CHANGE: this commit is a breaking change! Animation related code needs to be checked!
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #3436 (51bb998) into master (9e7fb70) will increase coverage by 9.86%.
Report is 852 commits behind head on master.
The diff coverage is n/a.

❗ Current head 51bb998 differs from pull request most recent head 9235bfd. Consider uploading reports for the commit 9235bfd to get more accurate results

@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   62.36%   72.22%   +9.86%     
==========================================
  Files          30       67      +37     
  Lines        1990     4554    +2564     
  Branches        0      560     +560     
==========================================
+ Hits         1241     3289    +2048     
- Misses        749     1220     +471     
- Partials        0       45      +45     

see 60 files with indirect coverage changes

@hippy-service
Copy link

hippy-service bot commented Aug 10, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Aug 10, 2023
@zealotchen0 zealotchen0 enabled auto-merge (squash) August 10, 2023 06:45
@zealotchen0 zealotchen0 merged commit 9899875 into Tencent:master Aug 10, 2023
12 of 16 checks passed
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Sep 26, 2023
zealotchen0 pushed a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action(squash-merge) Squash and merge action doc: example doc: pages framework: ios size: xl Denotes a PR that changes 1000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants