Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): listview performance optimization and bug fix #3572

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix(ios): listview performance optimization and bug fix #3572

merged 3 commits into from
Oct 30, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Oct 30, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added renderer: native doc: example size: s Denotes a PR that changes 10-99 lines labels Oct 30, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 30, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@tencent-adm
Copy link
Member

tencent-adm commented Oct 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wwwcg wwwcg added the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 30, 2023
@hippy-actions
Copy link

hippy-actions bot commented Oct 30, 2023

🔒 rebase-merge action execution needs privilege escalation.

Please wait for admin team member approval ...

@wwwcg

@wwwcg wwwcg had a problem deploying to github-actions-privileged October 30, 2023 03:45 — with GitHub Actions Failure
@wwwcg wwwcg added action(squash-merge) Squash and merge action and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Oct 30, 2023
@hippy-actions
Copy link

hippy-actions bot commented Oct 30, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@wwwcg

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Oct 30, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 30, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zealotchen0 zealotchen0 merged commit d8653ca into Tencent:main Oct 30, 2023
19 of 20 checks passed
ilikethese pushed a commit to ilikethese/Hippy that referenced this pull request Nov 7, 2023
@wwwcg @ilikethese
fix(ios): listview performance optimization and bug fix (Tencent#3572)
67d71c6 
* fix(ios): listview performance optimization and bug fix p1

* fix(ios): listview performance optimization and bug fix p2

* fix(ios): fix listview amendLayoutBeforeMount bug
@hippy-actions hippy-actions bot added the action(rebase-merge): failed Rebase and merge action execution failed label Nov 29, 2023
@wwwcg wwwcg deleted the hippy3_fix_2 branch January 12, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

Assignees
No one assigned
Labels
action(rebase-merge): failed Rebase and merge action execution failed action(squash-merge): failed Squash and merge action execution failed doc: example renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wwwcg @tencent-adm @ruifanyuan @zealotchen0