Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add orientationChange event for Modal #3861

Merged
merged 3 commits into from
May 17, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added driver: js renderer: native doc: pages size: m Denotes a PR that changes 100-499 lines labels May 16, 2024
Copy link

hippy-service bot commented May 16, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

zealotchen0
zealotchen0 previously approved these changes May 16, 2024
@siguangli siguangli added the action(squash-merge) Squash and merge action label May 16, 2024
Copy link

hippy-actions bot commented May 16, 2024

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels May 16, 2024
@siguangli siguangli merged commit 3a3364c into Tencent:main May 17, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action(squash-merge): failed Squash and merge action execution failed doc: pages driver: js renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants