Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtool): fix muli devtool instance crash on android #3862

Merged

Conversation

zealotchen0
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

Copy link

hippy-service bot commented May 17, 2024

Hi, @zealotchen0. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link
Collaborator

@etkmao etkmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zealotchen0 zealotchen0 merged commit 60fd4eb into Tencent:main May 20, 2024
20 of 21 checks passed
zealotchen0 added a commit to wangz2023/Hippy that referenced this pull request Jul 5, 2024
* fix(devtool): fix muli devtool instance crash on android

* fix(devtool): modify some comment
sohotz pushed a commit to sohotz/Hippy that referenced this pull request Jul 8, 2024
* Enhance pager component functionality

* Update: Switch Pager API to use NodeSwiperIndex

* add Pager call logic and coding standards

* Add boundary check for index in Call function, improve code style

* Modify: PagerView call function

* modify PagerView's Call function

* wangzheng debug

* update napi file

* change cmake setting

* debug

* update debug files

* update for debug

* feat(ohos): devtools compile

* supply mDevtoolsManager

* update HippyBridgeImpl.ets

* add debugMode

* feat(ohos): add devtools remote

* feat(ohos): add devtools remote

* fix codeCacheDir error

* feat(ohos): add download sync

* feat(ohos): add cache for devtools develop

* feat(ohos): support v8 devtools

* feat(ohos): modify devtools code

* update debugmode status

* fix code format error

* switch to capi

* fix(devtool): fix muli devtool instance crash on android (Tencent#3862)

* fix(devtool): fix muli devtool instance crash on android

* fix(devtool): modify some comment

* add DevServerImpl

* feat(ohos): delete signingConfigs

* feat(ohos): fix compile

* feat(ohos): modfiy http remote bundle loader

* feat(ohos): fix devtools compile -wdeprecated

* feat(ohos): modify devtools demo

* feat(ohos): modify devtools code

---------

Co-authored-by: wangzheng <513009828@qq.com>
Co-authored-by: WZ <9971672+wangz2023@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants