Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS13以下应用内切换主题后TabBar图片颜色不跟随主题变化 #813

Closed
evanzhou89 opened this issue Nov 10, 2019 · 6 comments
Closed
Labels

Comments

@evanzhou89
Copy link
Contributor

evanzhou89 commented Nov 10, 2019

Bug 表现
iOS12中在应用内切换theme,设置的tabBarItemImageColor并没有跟随theme改变

截图
屏幕快照 2019-11-10 下午2 26 56
Simulator Screen Shot - iPhone 8 Plus - 2019-11-10 at 14 26 46

如何重现
在QMUIDemo_iOS中QMUIConfigurationTemplateDark设置QMUICMI.tabBarItemImageColor, 然后应用切换Theme到Dark

预期的表现
应用内切换theme后tabbar item的图片颜色应该跟随设置的tabBarItemImageColor

其他信息

  • iOS 版本: iOS13以下
  • QMUI 版本: [4.0.3]
@evanzhou89 evanzhou89 changed the title 应用内切换themetabBarItemImageColor iOS12中应用内切换theme后tabBarItemImageColor无变化 Nov 10, 2019
@evanzhou89 evanzhou89 changed the title iOS12中应用内切换theme后tabBarItemImageColor无变化 iOS13以下应用内切换主题后TabBar图片颜色不跟随主题变化 Nov 10, 2019
@evanzhou89
Copy link
Contributor Author

简单看了下可能部分原因是在UITabBar+QMUI.m中强行指定original影响的,参考下图~
屏幕快照 2019-11-10 下午2 41 07
屏幕快照 2019-11-10 下午2 44 45

@LYluyu
Copy link

LYluyu commented Nov 13, 2019

我今天升级了之后也遇到了这个问题,在4.0.0的时候,没有这个问题的。

@LYluyu
Copy link

LYluyu commented Nov 18, 2019

@evanzhou1989 请问一下你们最后是增加图片资源来解决吗?

@evanzhou89
Copy link
Contributor Author

evanzhou89 commented Nov 18, 2019

@evanzhou1989 请问一下你们最后是增加图片资源来解决吗?

没有这么改,这应该算是库的Bug,还是等官方去fix吧

@MoLice MoLice added the bug label Nov 18, 2019
@MoLice
Copy link
Collaborator

MoLice commented Nov 18, 2019

这个是 QMUI 的 bug。

在 4.0.2 版本里为了修复 #736 的 bug,我们对 UITabBar (QMUI) 进行了修改,具体 commit diff 可点击查看 3fa84db#diff-250f11f1283ff2af409ffc265f61c475 。也正是因为该 commit,引发了本 issue 的问题。

下个版本会修复该问题。

@MoLice
Copy link
Collaborator

MoLice commented Dec 9, 2019

已发布 4.0.4 修复该问题。

@MoLice MoLice closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants