Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(domain): 清理domain的时候,移除挂载在domain的context #554

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

RobinzZH
Copy link
Collaborator

"nodejs里面EventEmitter初始化的时候,都会把当前的domain存下来。然后tsw里面又把整个请求的抓包存在domain.currentContext. 而数据库的PoolConnection类型又是继承EventEmitter的,Connection会一直存在,所以内存里就会一直有最初启动的几条流水线日志抓包。"

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #554 (29f0716) into master (8dcddc7) will increase coverage by 0.46%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   90.42%   90.89%   +0.46%     
==========================================
  Files          21       21              
  Lines         679      681       +2     
  Branches      112      119       +7     
==========================================
+ Hits          614      619       +5     
+ Misses         64       61       -3     
  Partials        1        1              
Files Changed Coverage Δ
lib/core/runtime/create-server.hack.ts 96.72% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

@RobinzZH RobinzZH merged commit 7d2e08e into master Aug 23, 2023
3 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants