Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 移除ShellUtil中对特定环境变量值过滤逻辑 #4821

Closed
irwinsun opened this issue Aug 2, 2021 · 0 comments
Closed

feat: 移除ShellUtil中对特定环境变量值过滤逻辑 #4821

irwinsun opened this issue Aug 2, 2021 · 0 comments
Labels
area/ci/agent 构建机Agent issue done Production environment in tencent has been deploy for gray UAT environment in tencent has been deploy for test Test environment in tencent has been deploy grayed uat环境测试通过/test passed for uat stage kind/enhancement 功能改进特性 tested 测试环境通过/test patest passed for test stage
Milestone
v1.7

Comments

@irwinsun
Copy link
Member

irwinsun commented Aug 2, 2021 •
edited
Loading

What would you like to be added:
早期 com.tencent.devops.worker.common.utils.ShellUtil 对 "|", "&", "(", ")" 4个字符进行过滤，如果变量值中存在该4个字符就不会被export,
随着后续优化，引入了单引号解决Bash脚本注入问题的，该4个字符已经不需要再被过滤了。

Why is this needed:

移除对变量值中存在 "|", "&", "(", ")" 的过滤，使之能被export到shell环境变量
@irwinsun irwinsun added kind/enhancement 功能改进特性 area/ci/agent 构建机Agent issue labels Aug 2, 2021
@irwinsun irwinsun added this to the v1.7 milestone Aug 2, 2021
hingbong added a commit to hingbong/bk-ci that referenced this issue Aug 3, 2021
@hingbong
feat: 移除ShellUtil中对特定环境变量值过滤逻辑 TencentBlueKing#4821
0cb6844
@bkci-bot bkci-bot added the for test Test environment in tencent has been deploy label Aug 3, 2021
irwinsun added a commit that referenced this issue Aug 3, 2021
@irwinsun
Merge pull request #4845 from hingbong/issue-#4821
f4e2966 
feat: 移除ShellUtil中对特定环境变量值过滤逻辑 #4821
@zanyzhao zanyzhao modified the milestones: v1.7, v1.8 Aug 4, 2021
@bkci-bot bkci-bot added the for gray UAT environment in tencent has been deploy label Aug 5, 2021
@irwinsun irwinsun added tested 测试环境通过/test patest passed for test stage grayed uat环境测试通过/test passed for uat stage labels Aug 5, 2021
@bkci-bot bkci-bot added the done Production environment in tencent has been deploy label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci/agent 构建机Agent issue done Production environment in tencent has been deploy for gray UAT environment in tencent has been deploy for test Test environment in tencent has been deploy grayed uat环境测试通过/test passed for uat stage kind/enhancement 功能改进特性 tested 测试环境通过/test patest passed for test stage
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
3 participants
@zanyzhao @irwinsun @bkci-bot