Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 插件流程控制支持设置允许失败后手动重试开关 #2175

Closed
KylinHuang7 opened this issue Jul 24, 2020 · 7 comments
Closed

feat: 插件流程控制支持设置允许失败后手动重试开关 #2175

KylinHuang7 opened this issue Jul 24, 2020 · 7 comments
Assignees
@carlyin0801 @iccengan @zhanxu33
Labels
area/ci/backend CI 后端issue area/ci/frontend CI 前端特性issue kind/feat/product 产品特性 priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.6

Comments

@KylinHuang7
Copy link

**Question, Bug, or Feature?
Type: Feature

Required Information

有些步骤不涉及环境问题上的失败（例如审批），允许重试可能会引发一些风险。
例如多个审批人，审批人A发现发布内容有风险给拒绝了；但审批人B也许没有发现到这个风险，点了重试后又通过了。
（当然，假如一开始就被审批人B通过了，也一样会将风险发布出去；但毕竟可以在风险已经被部分人员发现的情况下减少影响。）

因此，希望可以设置某些步骤“禁止重试”
@zanyzhao
Copy link
Member

嗯嗯，人工审核的插件确实特殊，可以考虑去掉重试功能，你这边还有没有其它的必须“禁止重试”的插件？

@zanyzhao zanyzhao added the question Needs more information label Jul 29, 2020
@KylinHuang7
Copy link
Author

KylinHuang7 commented Jul 29, 2020 •
edited
Loading

我觉得包含非幂等操作步骤的环节都应该可以设置禁止重试

@irwinsun irwinsun added area/ci/backend CI 后端issue and removed question Needs more information labels Oct 30, 2020
@irwinsun
Copy link
Member

irwinsun commented Oct 30, 2020 •
edited by iccengan
Loading

可为每个插件的控制流程新增一个开关： “允许失败时手动重试”
image

复用当前后台为前端操作有一个canRetry的字段判断，当执行失败流程结束后，可以在失败的插件中展示“重试”按钮
必须满足：

  • 插件执行失败了
  • 未开启“禁止失败后手动重试”
  • 未开启“失败时继续”

注：该特性需先上 #389。因为产品侧希望该选项默认关闭，当用户发现插件无法重试时，可通过 Job rebuild 来解决

@irwinsun irwinsun changed the title feature: 希望可以设置某些步骤禁止重试 feature: 插件流程控制支持设置禁止失败后手动重试 Oct 30, 2020
@irwinsun irwinsun changed the title feature: 插件流程控制支持设置禁止失败后手动重试 feature: 插件流程控制支持设置允许失败后手动重试 Nov 11, 2020
This was referenced Nov 11, 2020
Closed
Closed
Closed
@irwinsun irwinsun added area/ci/frontend CI 前端特性issue kind/feat/product 产品特性 labels Dec 4, 2020
@irwinsun irwinsun added this to the v1.3 milestone Dec 4, 2020
@zanyzhao zanyzhao removed this from the 2021.4-v1.5 milestone Apr 7, 2021
@zanyzhao zanyzhao added the review needed Needs pm reviews label Apr 7, 2021
@zanyzhao zanyzhao removed the review needed Needs pm reviews label May 21, 2021
@zanyzhao
Copy link
Member

再结合 #4245 就完美了

@zanyzhao zanyzhao added this to the v1.6 milestone May 21, 2021
@Toplife
Copy link

Toplife commented May 27, 2021

请支持下原子插件关闭重试的功能

@zanyzhao zanyzhao changed the title feature: 插件流程控制支持设置允许失败后手动重试 feat: 插件流程控制支持设置允许失败后手动重试 May 27, 2021
@zanyzhao zanyzhao changed the title feat: 插件流程控制支持设置允许失败后手动重试 feat: 插件流程控制支持设置允许失败后手动重试开关 May 27, 2021
@zanyzhao zanyzhao mentioned this issue May 27, 2021
Closed
@iccengan
Copy link

iccengan commented Jun 3, 2021

同 #933

@zanyzhao zanyzhao added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 3, 2021
@zanyzhao
Copy link
Member

zanyzhao commented Jun 9, 2021

Duplicate of #4245

@zanyzhao zanyzhao marked this as a duplicate of #4245 Jun 9, 2021
@zanyzhao zanyzhao closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlyin0801 carlyin0801

@iccengan iccengan

@zhanxu33 zhanxu33

Labels
area/ci/backend CI 后端issue area/ci/frontend CI 前端特性issue kind/feat/product 产品特性 priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
8 participants
@zanyzhao @carlyin0801 @KylinHuang7 @Toplife @iccengan @irwinsun @zhanxu33 @lockiechen