Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Agentless下的内置及商店插件混搭场景下,当内置插件出错且没有设置失败继续时无法自动结束 #2375

Closed
irwinsun opened this issue Aug 17, 2020 · 0 comments
Assignees
Labels
area/ci/backend CI 后端issue kind/bug 程序故障Bug,漏洞

Comments

@irwinsun
Copy link
Member

irwinsun commented Aug 17, 2020

image

编排

内置两个蓝盾内置插件(人工审核)以及一个通过研发商店上架的新插件

  1. 2-1 人工审核插件正常默认配置
  2. 2-2 人工审核插件的流程控制 执行条件设置为 [只有前面有插件运行失败时才运行]
  3. 2-3 插件正常默认配置

运行构建

  1. 2-1 时点击驳回 (将会触发状态失败, 在这里先不考虑驳回当成失败是否合理)
  2. 2-2 因2-1 驳回产生的失败状态, 满足了[只有前面有插件运行失败时才运行] 开始执行
  3. ContainerControl 解析后开始尝试等待agentless产生的容器进程来交互请求结束, 但是因为从没有启动过,导致无法结束,只能直到构建超时结束。

BUG原因

该问题为 #2046 issue重构时,为提升agentless的资源,直到插件真正需要agentless的容器资源才会启动 ,比如前置的2个人工审核插件不需要agentless启动容器资源来运行,所以将启动逻辑后置到新插件启动之前,而Job的流程控制器(ContainerControl)当前的处理逻辑没有考虑这类场景,导致出现bug

修复方案

#3400 解决

@irwinsun irwinsun added kind/bug 程序故障Bug,漏洞 area/ci/backend CI 后端issue labels Aug 17, 2020
@irwinsun irwinsun changed the title fix: 无编译环境下的内置及商店插件混搭场景下,当内置插件出错且没有设置失败继续时无法自动结束 fix: Agentless下的内置及商店插件混搭场景下,当内置插件出错且没有设置失败继续时无法自动结束 Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci/backend CI 后端issue kind/bug 程序故障Bug,漏洞
Projects
None yet
Development

No branches or pull requests

1 participant