Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[汇总] 降低问题排查成本, 降低整体复杂度 #405

Closed
18 of 26 tasks
wklken opened this issue May 7, 2022 · 3 comments
Closed
18 of 26 tasks

[汇总] 降低问题排查成本, 降低整体复杂度 #405

wklken opened this issue May 7, 2022 · 3 comments
Assignees
Labels
Layer: api Api module related Layer: login Login module related Layer: saas SaaS module related Module: LDAP/MAD ldap/mad related Module: plugin DataSource Plugin Priority: High Type: documentation Improvements or additions to documentation Type: enhancement Enhancement for existing feature Type: proposal Proposal

Comments

@wklken
Copy link
Collaborator

wklken commented May 7, 2022

现状

调用:

  • SaaS调用 API
  • ESB/APIGateway调用 API
  • API 数据同步模块
    • 调用LDAP
    • 调用 MAD
    • 调用 HTTP API
  • API 的auth模块(auth失败的场景)
  • SaaS 的登录校验模块(登录无限跳转的场景)
  • API 本身的校验报错信息

重点模块:

  • bkuser_core/enhanced_account
  • bkuser_core/esb_sdk
  • bkuser_core/categories/plugins

TODO: 收集其他用户返回的错误堆栈信息

日志

已经处理了:

还需要确定的点:

防御性处理

celery定时/异步

metrics

?

文档

  • LDAP/MAD数据同步问题 FAQ汇总
  • HTTP 数据源插件文档同步修改

其他

@wklken wklken added Type: documentation Improvements or additions to documentation Type: enhancement Enhancement for existing feature Layer: api Api module related Layer: saas SaaS module related Layer: login Login module related Type: proposal Proposal Module: plugin DataSource Plugin Module: LDAP/MAD ldap/mad related Module: 🔗sync data Priority: High labels May 7, 2022
@wklken wklken self-assigned this May 7, 2022
@wklken
Copy link
Collaborator Author

wklken commented Jul 4, 2022

修修补补加日志, 并没有真正解决问题, 降低问题排查的成本, 但是没有降低复杂度


本质上, 应该分析几个点, 从根本上减少概念/封装, 降低复杂度

  • saas通过sdk调用后台接口
  • 后台接口提供了过于通用的查询能力, 导致viewset层过于复杂(重点: category/profile)
  • 目录同步 plugins 机制(概念过多, 嵌套层级过深, 重点: 简化逻辑/减少封装)

@wklken
Copy link
Collaborator Author

wklken commented Jul 4, 2022

需要有: 明确的规划和方向

@wklken
Copy link
Collaborator Author

wklken commented Oct 31, 2022

  • SaaS 逻辑已抹除, 重构到API的 api/v1/web
  • SDK已抹除
  • 解耦了 Open API 和 SaaS API

@wklken wklken closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: api Api module related Layer: login Login module related Layer: saas SaaS module related Module: LDAP/MAD ldap/mad related Module: plugin DataSource Plugin Priority: High Type: documentation Improvements or additions to documentation Type: enhancement Enhancement for existing feature Type: proposal Proposal
Projects
None yet
Development

No branches or pull requests

2 participants