New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qbt cumulative versions use potentially insecure sha1 hash #9

Open

terabyte opened this issue Mar 2, 2018 · 1 comment

Labels

bug discussion qbt security

Member

terabyte commented Mar 2, 2018

The hashing code chooses sha1 here: https://github.com/TerabyteQbt/qbt/blob/a234d9d13d84701b0960299f9c5f3b516a005d07-qbt-6b09307ffd7af1eb7810d595108de34e502e512c/lib/main/src/qbt/QbtHashUtils.java

The sting that is hashed is generated here:
https://github.com/TerabyteQbt/qbt/blob/a234d9d13d84701b0960299f9c5f3b516a005d07-qbt-6b09307ffd7af1eb7810d595108de34e502e512c/app/main/src/qbt/recursive/cv/CumulativeVersion.java

Given that sha1 is now known to have collisions, we should have a plan for migrating to sha-256 or some other hash algorithm

terabyte added bug discussion qbt security labels

Member Author

terabyte commented Mar 19, 2018

If we change the hash, we should also change the "qbt version" constant (which is a randomly generated hash). It lives here: https://github.com/TerabyteQbt/qbt/blob/a234d9d13d84701b0960299f9c5f3b516a005d07-qbt-6b09307ffd7af1eb7810d595108de34e502e512c/app/main/src/qbt/recursive/cv/CumulativeVersionDigest.java#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment