Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown component doesn't handle links to other markdown files when offline #2193

Open
JulieMarie opened this issue Jul 18, 2024 · 0 comments · Fixed by #2194
Open

Markdown component doesn't handle links to other markdown files when offline #2193

JulieMarie opened this issue Jul 18, 2024 · 0 comments · Fixed by #2194

Comments

@JulieMarie
Copy link
Collaborator

JulieMarie commented Jul 18, 2024

Describe the bug
When creating urls for links to other markdown files in the markdown component, the component assumes an absolute path. For using IPH files offline, the component needs to handle relative paths as well as absolute paths.

To Reproduce
Steps to reproduce the behavior:

  1. Change IPH to host file for offline use
  2. Try to open a md file that calls out a link to another markdown file
  3. Note the error in the console

Expected behavior
User expects to see help files displayed properly whether they are online or offline

Screenshots
Online:
Screenshot 2024-07-18 at 12 12 38 PM

Offline:
Screenshot 2024-07-18 at 12 13 06 PM

Desktop (please complete the following information):

  • OS: macOS
  • Browser No browser, running Electron app
  • Version N/A

Additional context
N/A

@JulieMarie JulieMarie linked a pull request Jul 18, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant