Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify genes to use the 'Name' structure for property names #17

Open
vedant-shroff opened this issue Aug 29, 2020 · 0 comments
Open

Modify genes to use the 'Name' structure for property names #17

vedant-shroff opened this issue Aug 29, 2020 · 0 comments

Comments

@vedant-shroff
Copy link
Contributor

The genes are currently stored as regular strings in propertyDefinitionMaps as shown here,

private Map<String, GenePropertyDefinition> propertyDefinitionMap = new LinkedHashMap<>();

This could lead to problems during retrieval of trait values as there could be mismatch in upper and lower case. Using the Name structure from Gestalt (https://github.com/MovingBlocks/gestalt/blob/develop/gestalt-module/src/main/java/org/terasology/gestalt/naming/Name.java) would avoid unnecessary checks and modifications to Strings and work perfectly in this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants