Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In "panel completion", Mean Probability seems to be always 0 #154

Closed
jfcherng opened this issue May 17, 2024 · 5 comments
Closed

In "panel completion", Mean Probability seems to be always 0 #154

jfcherng opened this issue May 17, 2024 · 5 comments

Comments

@jfcherng
Copy link
Collaborator

jfcherng commented May 17, 2024

Originally asked in https://discord.com/channels/280102180189634562/645268178397560865/1241115323550142536.

That is, https://github.com/TerminalFi/LSP-copilot/blob/90b9176a7c22feb3dec75465c606aa4022cd1194/plugin/ui/panel_completion.py#L264C17-L264C21
image

The code is good but in the server payload it just says 0s. So I guess that Mean Probability only provides confusion now? But at the same time, we don't know those 0s are intentional or what.

Let's remove them from headers?

@timfjord
Copy link
Collaborator

If it is always 0, hiding it makes sense.
But has it been always like that? Maybe we are missing something in how we call the API

@jfcherng
Copy link
Collaborator Author

jfcherng commented May 21, 2024

If it is always 0, hiding it makes sense.
But has it been always like that? Maybe we are missing something in how we call the API

pretty sure it has other value back to when we implemented it. never saw 0 at that time.

@timfjord
Copy link
Collaborator

Hmm, then they probably changed something along the way.

@jfcherng
Copy link
Collaborator Author

This was it #18 (comment)

@TerminalFi
Copy link
Owner

Fixed / Removed in #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants