Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests and limits hardcoded #9

Closed
spinto opened this issue Mar 10, 2025 · 2 comments
Closed

Requests and limits hardcoded #9

spinto opened this issue Mar 10, 2025 · 2 comments

Comments

@spinto
Copy link

spinto commented Mar 10, 2025

Pod resources requests and limits seems to be hardcoded (see

pycalrissian/pycalrissian/job.py

Line 287 in b38e80e

requests={"cpu": "1000m", "memory": "1G"},
), and the CWL https://www.commonwl.org/v1.0/CommandLineTool.html#ResourceRequirement ignored. Is there any plan to update pycalrissian and fill K8S resource requests from the CWL?
@fabricebrito
Copy link
Member

These are the resources for the calrissian pod, not for pods spawned by calrissian.

@fabricebrito
Copy link
Member

@spinto can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabricebrito @spinto