-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAP Config Module Doesn't have token_bound_cidrs support #397
Comments
Something like this probably https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_oidc_auth_role.py#L65 Not hard to do, just adding the docs, parameters and any desired state type logic |
I can submit a PR tomorrow |
Unfortunately, HVAC doesn't support CIDRs yet for LDAP - I will have to get it added there first. How hard will it be to add guards in the code for folks that have HVAC <= the current version? |
I am also interested in the Anything we can do to unblock this, to get support for newer parameters? |
The easy thing to do would just add a token_bound_cidrs parameter to the current call |
I went ahead and proposed a PR that does exactly that. |
First off, love this module - amazing work.
Would you consider adding
token_bound_cidrs
to thehashivault_auth_ldap
module? Thankfully, you have this on OIDC roles and approles and it just appears to be missing on this one login method.Thank you for your consideration!
https://www.vaultproject.io/api/auth/ldap#token_bound_cidrs
The text was updated successfully, but these errors were encountered: