Skip to content

Commit

Permalink
fix(types/boolean): fix val.toLowerCase is no a function
Browse files Browse the repository at this point in the history
  • Loading branch information
CheerlessCloud committed Apr 10, 2018
1 parent 4e6bd2d commit 332e947
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/types/boolean.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class BooleanType extends ConfigFieldBaseType {
['true', 'false', '1', '0'].includes(val.toLowerCase());
});

this.transformators.post.push(val => ['true', '1'].includes(val.toLowerCase()));
this.transformators.post.push(val => ['true', '1'].includes(`${val}`.toLowerCase()));
}
}

Expand Down
6 changes: 6 additions & 0 deletions src/types/boolean.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,11 @@ describe('boolean type', () => {
booleanType.transformators.post.map(fn => expect(fn('false')).to.be.false);
booleanType.transformators.post.map(fn => expect(fn('FALSE')).to.be.false);
booleanType.transformators.post.map(fn => expect(fn('0')).to.be.false);

booleanType.transformators.post.map(fn => expect(fn(true)).to.be.true);
booleanType.transformators.post.map(fn => expect(fn(1)).to.be.true);
booleanType.transformators.post.map(fn => expect(fn(false)).to.be.false);
booleanType.transformators.post.map(fn => expect(fn(0)).to.be.false);
booleanType.transformators.post.map(fn => expect(fn({})).to.be.false);
});
});

0 comments on commit 332e947

Please sign in to comment.