Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in TestPackage serialization #14

Closed
CharliePoole opened this issue Nov 5, 2023 · 1 comment · Fixed by #15
Closed

Error in TestPackage serialization #14

CharliePoole opened this issue Nov 5, 2023 · 1 comment · Fixed by #15
Assignees
@CharliePoole
Labels
Bug Something isn't working as expected.
Milestone
2.0.0-beta4

Comments

@CharliePoole
Copy link
Contributor

The code for serialization in TestPackage.WriteXml works only when a Settings element is present. When there are no settings (which is rare) a package containing three subpackages

Package
  Subpackage1
  Subpackage2
  Subpackage3

is incorrectly serialized as if it were

Package
  Subpackage1
    Subpackage2
       Subpackage3

This is probably due to incorrect handling of EndElement in the code
@CharliePoole CharliePoole added the Bug Something isn't working as expected. label Nov 5, 2023
@CharliePoole CharliePoole added this to the 2.0.0-beta4 milestone Nov 5, 2023
@CharliePoole CharliePoole self-assigned this Nov 5, 2023
@CharliePoole CharliePoole mentioned this issue Nov 5, 2023
Merged
@CharliePoole
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.0.0-beta4 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharliePoole CharliePoole

Labels
Bug Something isn't working as expected.
Projects
None yet
Milestone
2.0.0-beta4
Development

Successfully merging a pull request may close this issue.

Fix deserialization bug; add more tests TestCentric/TestCentric.Engine.Api
1 participant
@CharliePoole