Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ISettings from Api #2

Closed
CharliePoole opened this issue Oct 31, 2023 · 1 comment · Fixed by #6
Closed

Remove ISettings from Api #2

CharliePoole opened this issue Oct 31, 2023 · 1 comment · Fixed by #6
Assignees
@CharliePoole
Labels
Breaking Change Breaking change requiring a new major version
Milestone
2.0.0-beta4

Comments

@CharliePoole
Copy link
Contributor

CharliePoole commented Oct 31, 2023 •
edited
Loading

Maintenance of settings is generally application-specific and out of scope for the engine. Settings for running and loading tests should be specified by making calls to the engine itself or by inclusion in the TestPackage.

This duplicates a change I made to the NUnit V4 Api.
@CharliePoole CharliePoole added this to the 2.0.0-beta4 milestone Oct 31, 2023
@CharliePoole CharliePoole self-assigned this Oct 31, 2023
@CharliePoole CharliePoole added the Breaking Change Breaking change requiring a new major version label Oct 31, 2023
@CharliePoole CharliePoole mentioned this issue Oct 31, 2023
Merged
@CharliePoole
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.0.0-beta4 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharliePoole CharliePoole

Labels
Breaking Change Breaking change requiring a new major version
Projects
None yet
Milestone
2.0.0-beta4
Development

Successfully merging a pull request may close this issue.

Remove ISettings interface TestCentric/TestCentric.Engine.Api
1 participant
@CharliePoole