-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changed event to TestPackage #32
Comments
CharliePoole
changed the title
Move IsDirty property from the gui runner to the engine API
Add Changed event to TestPackage
May 19, 2024
🎉 This issue has been resolved in version 2.0.0-beta6 🎉 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the runner TestCentricProject class inherits from TestPackage and implements an IsDirty property used to determine whether the project needs to be saved. The implementation is somewhat flawed because not all changes made to the base class are observable.
Moving the property to TestPackage itself will simplify the runner's job and be more reliable.In addition, it will give us a single implementation accessible to all runners.UPDATE: After some exploration, it seems cleaner to implement a Changed event which TestCentricProject can override.
It's possible that some other aspects of the TestCentricProject class will also need to be moved to the engine API. We'll examine that as part of this issue.
The text was updated successfully, but these errors were encountered: