Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to TestPackage Constructor #4

Closed
CharliePoole opened this issue Oct 31, 2023 · 1 comment · Fixed by #7
Closed

Changes to TestPackage Constructor #4

CharliePoole opened this issue Oct 31, 2023 · 1 comment · Fixed by #7
Assignees
Labels
Breaking Change Breaking change requiring a new major version
Milestone

Comments

@CharliePoole
Copy link
Contributor

CharliePoole commented Oct 31, 2023

TestPackage has two constructors, TestPackage(string) and TestPackage(IList<string>), with entirely different semantics. The string constructor is intended for use with subpackages only but nothing prevents the caller for using it for the top-level constructor. This is confusing for the caller and requires our code to make provision for either constructor being used. It also doubles the effort of maintaining tests that make use of TestPackage. The string constructor will be removed and a method added to create subpackages under the top-level package.

This duplicates a change I made to the NUnit V4 Api.

@CharliePoole CharliePoole added this to the 2.0.0-beta4 milestone Oct 31, 2023
@CharliePoole CharliePoole self-assigned this Oct 31, 2023
@CharliePoole CharliePoole added the Breaking Change Breaking change requiring a new major version label Oct 31, 2023
@CharliePoole
Copy link
Contributor Author

🎉 This issue has been resolved in version 2.0.0-beta4 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Breaking change requiring a new major version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant