Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit dependency on jQuery #13

Open
koliyo opened this issue Dec 25, 2020 · 3 comments
Open

Implicit dependency on jQuery #13

koliyo opened this issue Dec 25, 2020 · 3 comments

Comments

@koliyo
Copy link

koliyo commented Dec 25, 2020

This component does not work without jQuery

ReferenceError: $ is not defined

And this is resolved by explicitly loading the jQuery CDN.

But even better would be if this component did not depend on jQuery.

@koliyo
Copy link
Author

koliyo commented Dec 25, 2020

I have remove jquery and added some more recent json-viewer functionality in this fork, https://github.com/koliyo/JsonViewer

@Texnomic
Copy link
Owner

Perfect, thank you, now please create a PR and I'll gladly merge it.

@SoleCode
Copy link

SoleCode commented Jan 6, 2023

@Texnomic I have upgraded the code to .NET 7 and added @koliyo changes in my local. However, I don't permission to push my branch and create a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants